From 3bc28e2e20fdd06aa93b9716c1497c46778c9c0a Mon Sep 17 00:00:00 2001 From: Johnny D Date: Fri, 10 Jan 2025 09:55:11 -0500 Subject: [PATCH 1/6] remove superfluous top border from table charts --- src/components/charts/composed.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/components/charts/composed.ts b/src/components/charts/composed.ts index bae70c0e..b41c71db 100644 --- a/src/components/charts/composed.ts +++ b/src/components/charts/composed.ts @@ -162,9 +162,7 @@ export default class AstraComposedChart extends AstraChart { // render chart const showNoDataLabel = (layer?.result === undefined || layer?.result?.length === 0) && layer?.type !== 'text' const chart = showNoDataLabel ? null : super.render() - const chartSection = html`
+ const chartSection = html`
${showNoDataLabel ? html` Date: Fri, 10 Jan 2025 10:25:26 -0500 Subject: [PATCH 2/6] disable problematic (and unnecessary?) backdrop it breaks transparency --- src/components/table/core/td.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/table/core/td.ts b/src/components/table/core/td.ts index 4f0ea820..9e38bf20 100644 --- a/src/components/table/core/td.ts +++ b/src/components/table/core/td.ts @@ -247,7 +247,7 @@ export class TableData extends MutableElement { 'relative focus:z-[1]': true, 'h-[34px] flex items-center justify-center': true, 'border-theme-table-border dark:border-theme-table-border-dark': true, - 'backdrop-blur-sm': this.blank || this.pinned, + // 'backdrop-blur-sm': this.blank || this.pinned, // TODO support odd vs even again 'text-theme-table-content dark:text-theme-table-content-dark': !this.isEditing, 'text-theme-table-cell-mutating-content dark:text-theme-table-cell-mutating-content': this.isEditing, From 3f72553e0e5effcc144719325a247f1aac1c1fb6 Mon Sep 17 00:00:00 2001 From: Johnny D Date: Fri, 10 Jan 2025 10:25:55 -0500 Subject: [PATCH 3/6] v0.8.12 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 7f6eaa38..0f55e598 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@outerbase/astra-ui", - "version": "0.8.11", + "version": "0.8.12", "type": "module", "main": "dist/js/index.js", "module": "dist/js/index.js", From 79a5a01ae4fb1ac826b3f877fab2be68c595c2f4 Mon Sep 17 00:00:00 2001 From: Johnny D Date: Fri, 10 Jan 2025 15:49:09 -0500 Subject: [PATCH 4/6] debounce resize observer --- src/components/charts/chart.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/components/charts/chart.ts b/src/components/charts/chart.ts index ca2cad07..32dece35 100644 --- a/src/components/charts/chart.ts +++ b/src/components/charts/chart.ts @@ -29,6 +29,7 @@ import type { import { unsafeHTML } from 'lit/directives/unsafe-html.js' import { isDate } from '../../lib/format-date.js' import { OUTERBASE_API_DOMAIN } from '../../variables.js' +import { debounce } from 'lodash-es' // Register the required components echarts.use([ @@ -543,7 +544,7 @@ export default class AstraChart extends ClassifiedElement { } private setupResizeObserver() { - this.resizeObserver = new ResizeObserver((entries) => { + const onResize = debounce((entries: ResizeObserverEntry[]) => { for (const entry of entries) { if (entry.target === this.chartDiv) { const { width, height } = entry.contentRect @@ -556,7 +557,9 @@ export default class AstraChart extends ClassifiedElement { } } } - }) + }, 50) + + this.resizeObserver = new ResizeObserver(onResize) if (this.chartDiv) { this.resizeObserver.observe(this.chartDiv) From 8d5eaf2fc810c738806217504aa5cd39029cd6cd Mon Sep 17 00:00:00 2001 From: Johnny D Date: Fri, 10 Jan 2025 15:49:29 -0500 Subject: [PATCH 5/6] repair resize observer that was firing too soon --- src/components/charts/chart.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/components/charts/chart.ts b/src/components/charts/chart.ts index 32dece35..56201b3c 100644 --- a/src/components/charts/chart.ts +++ b/src/components/charts/chart.ts @@ -255,9 +255,7 @@ export default class AstraChart extends ClassifiedElement { override firstUpdated(_changedProperties: PropertyValueMap) { super.firstUpdated(_changedProperties) - this.initializeChart() - this.setupResizeObserver() } override updated(_changedProperties: PropertyValueMap | Map): void { @@ -335,6 +333,13 @@ export default class AstraChart extends ClassifiedElement { this.chartInstance = echarts.init(this.chartDiv, undefined, { renderer: 'canvas' }) this.chartInstance.setOption(this.getChartOptions()) + + if (this.resizeObserver) { + this.resizeObserver.disconnect() + delete this.resizeObserver + } + + this.setupResizeObserver() } private labelFormatter(value: unknown): string { From 964d49e55c59d20f7c5152144accb0e45b16950c Mon Sep 17 00:00:00 2001 From: Johnny D Date: Fri, 10 Jan 2025 15:50:20 -0500 Subject: [PATCH 6/6] v0.8.13 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 0f55e598..4df32ae9 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@outerbase/astra-ui", - "version": "0.8.12", + "version": "0.8.13", "type": "module", "main": "dist/js/index.js", "module": "dist/js/index.js",