From b98f694daa16818714c722e8eb9615219d120438 Mon Sep 17 00:00:00 2001 From: Prabinder Singh Date: Tue, 10 Mar 2026 20:41:30 +0530 Subject: [PATCH] fix: correct run_time_limit default unit from seconds to minutes SLURM interprets bare integers as minutes, not seconds. 432000 seconds (5 * 24 * 60 * 60) = 300 days in SLURM, not 5 days. Corrected to 7200 (5 * 24 * 60) = 5 days in minutes. Updated help text and comment accordingly. --- metaflow_extensions/slurm_ext/plugins/slurm/slurm_cli.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/metaflow_extensions/slurm_ext/plugins/slurm/slurm_cli.py b/metaflow_extensions/slurm_ext/plugins/slurm/slurm_cli.py index 880ac5d..0e01bf4 100644 --- a/metaflow_extensions/slurm_ext/plugins/slurm/slurm_cli.py +++ b/metaflow_extensions/slurm_ext/plugins/slurm/slurm_cli.py @@ -74,8 +74,8 @@ def slurm(): ) @click.option( "--run-time-limit", - default=5 * 24 * 60 * 60, # Default is set to 5 days - help="Run time limit in seconds for Slurm job.", + default=5 * 24 * 60, # Default is set to 5 days (in minutes, as SLURM interprets bare integers as minutes) + help="Run time limit in minutes for Slurm job.", ) @click.pass_context def step(