Skip to content

Commit 4479af5

Browse files
authored
Remove prevent_destroy on S3 bucket
I understand this was introduced for parity with CFN but unlike CFN "Retain" policy, setting this on S3 bucket resource effectively prevents the module user from being able to destroy _anything_ in the stack (without forking the module and removing prevent_destroy).
1 parent 93d3212 commit 4479af5

File tree

1 file changed

+0
-4
lines changed
  • aws/terraform/modules/metaflow/modules/datastore

1 file changed

+0
-4
lines changed

aws/terraform/modules/metaflow/modules/datastore/s3.tf

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ resource "aws_s3_bucket" "this" {
1616
Metaflow = "true"
1717
}
1818
)
19-
20-
lifecycle {
21-
prevent_destroy = true
22-
}
2319
}
2420

2521
resource "aws_s3_bucket_public_access_block" "this" {

0 commit comments

Comments
 (0)