Skip to content

Commit a19f9c8

Browse files
authored
add missing kms permissions related to s3 (#8)
1 parent d795b6e commit a19f9c8

File tree

2 files changed

+8
-5
lines changed
  • aws/terraform/modules/metaflow

2 files changed

+8
-5
lines changed

aws/terraform/modules/metaflow/iam.tf

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,10 @@ data "aws_iam_policy_document" "s3_kms" {
6161
statement {
6262
effect = "Allow"
6363

64-
# TODO - reduce to Encrypt, Decrypt?
6564
actions = [
6665
"kms:Decrypt",
6766
"kms:Encrypt",
68-
# "kms:ReEncryptTo",
69-
# "kms:ReEncryptFrom",
70-
# "kms:DescribeKey",
71-
# "kms:GenerateDataKey"
67+
"kms:GenerateDataKey"
7268
]
7369

7470
resources = [
@@ -224,6 +220,12 @@ resource "aws_iam_role_policy" "grant_custom_s3_batch" {
224220
policy = data.aws_iam_policy_document.custom_s3_batch.json
225221
}
226222

223+
resource "aws_iam_role_policy" "grant_s3_kms" {
224+
name = "s3_kms"
225+
role = aws_iam_role.batch_s3_task_role.name
226+
policy = data.aws_iam_policy_document.s3_kms.json
227+
}
228+
227229
resource "aws_iam_role_policy" "grant_deny_presigned_batch" {
228230
name = "deny_presigned"
229231
role = aws_iam_role.batch_s3_task_role.name

aws/terraform/modules/metaflow/modules/metadata-service/iam.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ data "aws_iam_policy_document" "s3_kms" {
3131
actions = [
3232
"kms:Decrypt",
3333
"kms:Encrypt",
34+
"kms:GenerateDataKey"
3435
]
3536

3637
resources = [

0 commit comments

Comments
 (0)