Add manual line management, unique IDs, and config improvements

Introduces manual line creation, editing, and removal via new /railway line subcommands with granular permission checks. Adds short unique hex IDs for lines, minimum line length filtering, and improved debug logging. Updates config and permissions structure, enhances map rendering, and expands documentation in README.

Author: outsharded

README.md

@@ -61,14 +61,21 @@ public void apiEnabled(DynmapCommonAPI api) {
                 }
 
                 // Initialize map renderer
-                getLogger().info("[DEBUG] About to initialize map renderer...");
+                boolean debugEnabled = getConfig().getBoolean("general.debug", false);
+                if (debugEnabled) {
+                    getLogger().info("[DEBUG] About to initialize map renderer...");
+                }
                 mapRenderer = new RailwayMapRenderer(DynmapRailways.this, dynmapAPI, dataStorage);
-                getLogger().info("[DEBUG] RailwayMapRenderer created, calling initialize()...");
+                if (debugEnabled) {
+                    getLogger().info("[DEBUG] RailwayMapRenderer created, calling initialize()...");
+                }
                 mapRenderer.initialize();
-                getLogger().info("[DEBUG] Railway map renderer initialization complete.");
+                if (debugEnabled) {
+                    getLogger().info("[DEBUG] Railway map renderer initialization complete.");
+                }
 
                 // Provide CoreProtect integration to scanner (optional)
-                com.fabianoley.dynmaprailways.scan.RailScanner.setCoreProtectIntegration(coreProtect);
+                com.fabianoley.dynmaprailways.scan.RailScanner.setCoreProtectIntegration(coreProtect, DynmapRailways.this);
 
                 // Register commands
                 registerCommands();

src/main/java/com/fabianoley/dynmaprailways/DynmapRailways.java

@@ -37,47 +37,68 @@ public RailwayMapRenderer(DynmapRailways plugin, DynmapCommonAPI dynmapAPI, Rail
         // No CoreProtect filtering
     }
 
+    /**
+     * Check if debug mode is enabled.
+     */
+    private boolean isDebugEnabled() {
+        return plugin.getConfig().getBoolean("general.debug", false);
+    }
+    
     /**
      * Initialize the map renderer.
      */
     public void initialize() {
-        logger.info("[DEBUG] Starting RailwayMapRenderer initialization...");
+        if (isDebugEnabled()) {
+            logger.info("[DEBUG] Starting RailwayMapRenderer initialization...");
+        }
         // Touch plugin to avoid unused field warning and for debugging context
         if (plugin != null) {
-            logger.fine("[DEBUG] Renderer initialized for plugin: " + plugin.getClass().getName());
+            if (isDebugEnabled()) {
+                logger.fine("[DEBUG] Renderer initialized for plugin: " + plugin.getClass().getName());
+            }
         }
 
-        // No CoreProtect filtering
-
         if (dynmapAPI == null) {
             logger.severe("[DEBUG] Dynmap API is null!");
             return;
         }
-        logger.info("[DEBUG] Dynmap API found: " + dynmapAPI.getClass().getName());
+        if (isDebugEnabled()) {
+            logger.info("[DEBUG] Dynmap API found: " + dynmapAPI.getClass().getName());
+        }
 
         // Get Marker API
         markerAPI = dynmapAPI.getMarkerAPI();
-        logger.info("[DEBUG] Marker API retrieved: " + (markerAPI != null ? markerAPI.getClass().getName() : "null"));
+        if (isDebugEnabled()) {
+            logger.info("[DEBUG] Marker API retrieved: " + (markerAPI != null ? markerAPI.getClass().getName() : "null"));
+        }
 
         if (markerAPI == null) {
             logger.severe("[DEBUG] Dynmap Marker API not available!");
             return;
         }
 
         // Get or create marker sets
-        logger.info("[DEBUG] Creating marker sets...");
+        if (isDebugEnabled()) {
+            logger.info("[DEBUG] Creating marker sets...");
+        }
         createMarkerSets();
 
-        logger.info("[DEBUG] Railway marker set: " + (railwayMarkerSet != null ? railwayMarkerSet.getClass().getName() : "null"));
-        logger.info("[DEBUG] Station marker set: " + (stationMarkerSet != null ? stationMarkerSet.getClass().getName() : "null"));
+        if (isDebugEnabled()) {
+            logger.info("[DEBUG] Railway marker set: " + (railwayMarkerSet != null ? railwayMarkerSet.getClass().getName() : "null"));
+            logger.info("[DEBUG] Station marker set: " + (stationMarkerSet != null ? stationMarkerSet.getClass().getName() : "null"));
+        }
 
         if (railwayMarkerSet == null || stationMarkerSet == null) {
-            logger.warning("[DEBUG] Failed to create marker sets");
+            if (isDebugEnabled()) {
+                logger.warning("[DEBUG] Failed to create marker sets");
+            }
             return;
         }
 
         // Initial render
-        logger.info("[DEBUG] Updating all markers...");
+        if (isDebugEnabled()) {
+            logger.info("[DEBUG] Updating all markers...");
+        }
         updateAllMarkers();
 
         logger.info("Railway map renderer initialized successfully.");
@@ -87,23 +108,35 @@ public void initialize() {
      * Create or get marker sets.
      */
     private void createMarkerSets() {
-        logger.info("[DEBUG] createMarkerSets() called");
+        if (isDebugEnabled()) {
+            logger.info("[DEBUG] createMarkerSets() called");
+        }
         // Get marker sets
         railwayMarkerSet = markerAPI.getMarkerSet(MARKER_SET_ID);
         stationMarkerSet = markerAPI.getMarkerSet(STATIONS_SET_ID);
-        logger.info("[DEBUG] Retrieved existing marker sets: railway=" + (railwayMarkerSet != null) + ", station=" + (stationMarkerSet != null));
+        if (isDebugEnabled()) {
+            logger.info("[DEBUG] Retrieved existing marker sets: railway=" + (railwayMarkerSet != null) + ", station=" + (stationMarkerSet != null));
+        }
 
         // Create if missing
         if (railwayMarkerSet == null) {
-            logger.info("[DEBUG] Railway marker set is null, attempting to create...");
+            if (isDebugEnabled()) {
+                logger.info("[DEBUG] Railway marker set is null, attempting to create...");
+            }
             railwayMarkerSet = markerAPI.createMarkerSet(MARKER_SET_ID, "Railway Lines", null, false);
-            logger.info("[DEBUG] Created Railway Lines marker set successfully");
+            if (isDebugEnabled()) {
+                logger.info("[DEBUG] Created Railway Lines marker set successfully");
+            }
         }
 
         if (stationMarkerSet == null) {
-            logger.info("[DEBUG] Station marker set is null, attempting to create...");
+            if (isDebugEnabled()) {
+                logger.info("[DEBUG] Station marker set is null, attempting to create...");
+            }
             stationMarkerSet = markerAPI.createMarkerSet(STATIONS_SET_ID, "Railway Stations", null, false);
-            logger.info("[DEBUG] Created Railway Stations marker set successfully");
+            if (isDebugEnabled()) {
+                logger.info("[DEBUG] Created Railway Stations marker set successfully");
+            }
         }
 
         // Set layer priorities - higher priority renders on top
@@ -121,10 +154,14 @@ private void createMarkerSets() {
      */
     public void updateAllMarkers() {
         try {
-            logger.info("[DEBUG] updateAllMarkers() called");
+            if (isDebugEnabled()) {
+                logger.info("[DEBUG] updateAllMarkers() called");
+            }
 
             if (railwayMarkerSet == null || stationMarkerSet == null) {
-                logger.warning("[DEBUG] Marker sets not available - cannot render");
+                if (isDebugEnabled()) {
+                    logger.warning("[DEBUG] Marker sets not available - cannot render");
+                }
                 return;
             }
 
@@ -136,34 +173,50 @@ public void updateAllMarkers() {
             // Clear old markers
             clearMarkers(railwayMarkerSet);
             clearMarkers(stationMarkerSet);
-            logger.info("[DEBUG] Cleared old markers");
+            if (isDebugEnabled()) {
+                logger.info("[DEBUG] Cleared old markers");
+            }
 
             // Render rail lines
             Map<String, RailLine> railLines = dataStorage.getRailLines();
-            logger.info("[DEBUG] Found " + railLines.size() + " rail lines to render");
+            if (isDebugEnabled()) {
+                logger.info("[DEBUG] Found " + railLines.size() + " rail lines to render");
+            }
 
             boolean playerPlacedOnly = plugin.getConfig().getBoolean("coreprotect.player-placed-only", true);
             for (RailLine line : railLines.values()) {
-                logger.info("[DEBUG] Processing line: " + line.getId() + " with " + line.getBlockCount() + " blocks, active=" + line.isActive());
+                if (isDebugEnabled()) {
+                    logger.info("[DEBUG] Processing line: " + line.getId() + " with " + line.getBlockCount() + " blocks, active=" + line.isActive());
+                }
                 if (line.isActive() && line.getBlockCount() > 1 && (!playerPlacedOnly || line.getCreatedBy() != null)) {
                     renderRailLine(line);
-                    logger.info("[DEBUG] Rendered line: " + line.getId());
+                    if (isDebugEnabled()) {
+                        logger.info("[DEBUG] Rendered line: " + line.getId());
+                    }
                 }
             }
 
             // Render stations
             Map<String, Station> stations = dataStorage.getStations();
-            logger.info("[DEBUG] Found " + stations.size() + " stations to render");
+            if (isDebugEnabled()) {
+                logger.info("[DEBUG] Found " + stations.size() + " stations to render");
+            }
 
             for (Station station : stations.values()) {
-                logger.info("[DEBUG] Processing station: " + station.getId() + ", active=" + station.isActive());
+                if (isDebugEnabled()) {
+                    logger.info("[DEBUG] Processing station: " + station.getId() + ", active=" + station.isActive());
+                }
                 if (station.isActive()) {
                     renderStation(station);
-                    logger.info("[DEBUG] Rendered station: " + station.getId());
+                    if (isDebugEnabled()) {
+                        logger.info("[DEBUG] Rendered station: " + station.getId());
+                    }
                 }
             }
 
-            logger.info("[DEBUG] updateAllMarkers() completed successfully");
+            if (isDebugEnabled()) {
+                logger.info("[DEBUG] updateAllMarkers() completed successfully");
+            }
         } catch (Exception e) {
             logger.warning("Error updating markers: " + e.getMessage());
             e.printStackTrace();
@@ -379,7 +432,7 @@ private void renderStation(Station station) {
         // Get station appearance settings from config (with defaults)
         double radius = plugin.getConfig().getDouble("stations.radius", 5.0);
         String fillColorHex = plugin.getConfig().getString("stations.fill-color", "#FFFFFF");
-        double fillOpacity = plugin.getConfig().getDouble("stations.fill-opacity", 0.9);
+        double fillOpacity = plugin.getConfig().getDouble("stations.fill-opacity", 0.3);
         int borderWidth = plugin.getConfig().getInt("stations.border-width", 2);
         String borderColorHex = plugin.getConfig().getString("stations.border-color", "#000000");
         double borderOpacity = plugin.getConfig().getDouble("stations.border-opacity", 1.0);

src/main/java/com/fabianoley/dynmaprailways/commands/RailwayCommand.java

@@ -4,6 +4,7 @@
 import org.bukkit.block.Block;
 import org.bukkit.Material;
 
+import com.fabianoley.dynmaprailways.DynmapRailways;
 import com.fabianoley.dynmaprailways.integration.CoreProtectIntegration;
 import com.fabianoley.dynmaprailways.rail.RailLine;
 import com.fabianoley.dynmaprailways.rail.RailLine.RailBlock;
@@ -17,9 +18,15 @@ public class RailScanner {
 
     private static final Logger logger = Logger.getLogger("DynmapRailways");
     private static CoreProtectIntegration coreProtect;
+    private static DynmapRailways plugin;
 
-    public static void setCoreProtectIntegration(CoreProtectIntegration integration) {
+    public static void setCoreProtectIntegration(CoreProtectIntegration integration, DynmapRailways pluginInstance) {
         coreProtect = integration;
+        plugin = pluginInstance;
+    }
+
+    private static boolean isDebugEnabled() {
+        return plugin != null && plugin.getConfig().getBoolean("general.debug", false);
     }
 
     /**
@@ -131,8 +138,10 @@ public static List<RailLine> mergeWithExistingLines(World world, List<RailLine>
                     blocksInExistingLines.add(block);
                 }
 
-                logger.info("Added new line " + newLine.getId() + " (" + newLine.getBlockCount() + " blocks, " + 
-                           (int)(overlapRatio * 100) + "% overlap)");
+                if (isDebugEnabled()) {
+                    logger.info("Added new line " + newLine.getId() + " (" + newLine.getBlockCount() + " blocks, " + (int)(overlapRatio * 100) + "% overlap)");
+                }
+
             }
         }
 
@@ -229,6 +238,13 @@ private static boolean isRailBlock(Block block) {
      * Lines are traced from endpoints (1 neighbor) following the path until reaching another endpoint.
      */
     private static List<RailLine> clusterRails(World world, Set<RailBlock> allRails) {
+        return clusterRailsWithIdGenerator(world, allRails, null);
+    }
+    
+    /**
+     * Cluster rails with optional ID generator for creating unique IDs.
+     */
+    private static List<RailLine> clusterRailsWithIdGenerator(World world, Set<RailBlock> allRails, java.util.function.Supplier<String> idGenerator) {
         List<RailLine> lines = new ArrayList<>();
         Set<RailBlock> visited = new HashSet<>();
         String[] colors = getTflColors();
@@ -353,8 +369,9 @@ private static List<RailLine> clusterRails(World world, Set<RailBlock> allRails)
 
             // Create line if it has more than one block
             if (line.size() > 1) {
+                String lineId = idGenerator != null ? idGenerator.get() : "tmp_" + lines.size();
                 RailLine railLine = new RailLine(
-                        "line_" + lines.size(),
+                        lineId,
                         colors[colorIndex % colors.length]
                 );
                 railLine.addBlocks(line);
@@ -378,8 +395,9 @@ private static List<RailLine> clusterRails(World world, Set<RailBlock> allRails)
             if (!visited.contains(rail)) {
                 Set<RailBlock> cluster = dfsCluster(rail, neighborMap, new HashSet<>());
                 if (!cluster.isEmpty()) {
+                    String lineId = idGenerator != null ? idGenerator.get() : "tmp_" + lines.size();
                     RailLine railLine = new RailLine(
-                            "line_" + lines.size(),
+                            lineId,
                             colors[colorIndex % colors.length]
                     );
                     railLine.addBlocks(cluster);

src/main/java/com/fabianoley/dynmaprailways/map/RailwayMapRenderer.java

@@ -50,6 +50,35 @@ private void ensureDataFolder() {
         }
     }
 
+    /**
+     * Generate a short unique hex ID for a rail line.
+     * Starts with 3 characters and grows if needed to avoid collisions.
+     */
+    public String generateLineId() {
+        Random random = new Random();
+        int length = 3;
+        int maxAttempts = 100;
+        
+        while (length <= 8) { // Max 8 characters
+            for (int attempt = 0; attempt < maxAttempts; attempt++) {
+                StringBuilder id = new StringBuilder();
+                for (int i = 0; i < length; i++) {
+                    id.append(Integer.toHexString(random.nextInt(16)));
+                }
+                String candidate = id.toString();
+                
+                // Check if this ID is already in use
+                if (!railLines.containsKey(candidate)) {
+                    return candidate;
+                }
+            }
+            length++; // Grow length if we couldn't find unique ID
+        }
+        
+        // Fallback to timestamp-based if somehow we still have collisions
+        return Long.toHexString(System.currentTimeMillis());
+    }
+    
     /**
      * Load all data from storage.
      */
@@ -198,6 +227,23 @@ public void replaceAllRailLines(List<RailLine> newLines) throws Exception {
         logger.info("Replaced all rail lines. Now storing " + railLines.size() + " lines.");
     }
 
+    /**
+     * Replace all rail lines with filtering by minimum length from config.
+     */
+    public void replaceAllRailLinesFiltered(List<RailLine> newLines, int minLength) throws Exception {
+        railLines.clear();
+        int filtered = 0;
+        for (RailLine line : newLines) {
+            if (line.getBlockCount() >= minLength) {
+                railLines.put(line.getId(), line);
+            } else {
+                filtered++;
+            }
+        }
+        saveRailLines();
+        logger.info("Replaced all rail lines. Now storing " + railLines.size() + " lines (filtered " + filtered + " lines below minimum length).");
+    }
+    
     /**
      * Clear all data.
      */

src/main/java/com/fabianoley/dynmaprailways/scan/RailScanner.java

@@ -1,5 +1,13 @@
 # DynmapRailways Configuration
 
+# General settings
+general:
+  # Enable debug logging to console
+  debug: false
+  # Minimum number of blocks required for a line to be saved
+  # Lines with fewer blocks will be ignored
+  min-line-length: 15
+
 # CoreProtect integration settings
 coreprotect:
   # Enable or disable CoreProtect integration
@@ -26,7 +34,7 @@ stations:
   # Fill color (hex color code)
   fill-color: "#FFFFFF"
   # Fill opacity (0.0 to 1.0)
-  fill-opacity: 0.9
+  fill-opacity: 0.5
   # Border line width (in pixels)
   border-width: 2
   # Border color (hex color code)