feat: upgrade to prow v20200427-baaf248ed (#84)

* fix: remove not needed prowjobNamespace var

* fix: make crier rbac namespaced

* fix: update hook rbac

* fix: add github cache to hook

* fix: add github cache to crier

* fix: add secondary github endpoint

Author: alexouzounis

prow/templates/config-configmap.yaml

@@ -10,5 +10,5 @@ metadata:
     "helm.sh/hook-delete-policy": "before-hook-creation"
 data:
   config.yaml: |-
-    prowjob_namespace: {{ .Values.prowjobNamespace }}
+    prowjob_namespace: {{ .Release.Namespace }}
     pod_namespace: {{ .Values.podNamespace }}

prow/templates/crier-deployment.yaml

@@ -30,7 +30,7 @@ spec:
         - --config-path=/etc/config/config.yaml
         - --job-config-path=/etc/job-config
         - --github-endpoint=http://ghproxy
-#        - --github-endpoint=https://api.github.com
+        - --github-endpoint=https://api.github.com
         volumeMounts:
         - name: config
           mountPath: /etc/config

prow/templates/crier-rbac.yaml

@@ -3,10 +3,9 @@ apiVersion: v1
 metadata:
   name: "crier"
 ---
-kind: ClusterRole
+kind: Role
 apiVersion: rbac.authorization.k8s.io/v1
 metadata:
-  # "namespace" omitted since ClusterRoles are not namespaced
   name: crier
 rules:
 - apiGroups:
@@ -18,6 +17,13 @@ rules:
     - "watch"
     - "list"
     - "patch"
+---
+kind: Role
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: crier
+  namespace: {{ .Values.podNamespace }}
+rules:
 - apiGroups:
     - ""
   resources:
@@ -27,13 +33,26 @@ rules:
     - "get"
     - "list"
 ---
-kind: ClusterRoleBinding
+kind: RoleBinding
 apiVersion: rbac.authorization.k8s.io/v1beta1
 metadata:
+  name: crier-namespaced
+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: Role
   name: "crier"
+subjects:
+- kind: ServiceAccount
+  name: "crier"
+---
+kind: RoleBinding
+apiVersion: rbac.authorization.k8s.io/v1beta1
+metadata:
+  name: crier-namespaced
+  namespace: {{ .Values.podNamespace }}
 roleRef:
   apiGroup: rbac.authorization.k8s.io
-  kind: ClusterRole
+  kind: Role
   name: "crier"
 subjects:
 - kind: ServiceAccount

prow/templates/deck-deployment.yaml

@@ -27,18 +27,20 @@ spec:
       - name: deck
         image: {{ quote .Values.deck.image }}
         args:
-        - --rerun-creates-job
         - --config-path=/etc/config/config.yaml
         - --tide-url=http://tide/
         - --hook-url=http://hook:8888/plugin-help
         - --redirect-http-to={{ quote .Values.deck.host }}
+        - --oauth-url=/github-login
         - --config-path=/etc/config/config.yaml
-        - --cookie-secret=/etc/cookie/secret
         - --job-config-path=/etc/job-config
-        - --oauth-url=/github-login
         - --spyglass=true
+        - --rerun-creates-job
         - --github-token-path=/etc/github/oauth
+        - --github-endpoint=http://ghproxy
+        - --github-endpoint=https://api.github.com
         - --github-oauth-config-file=/etc/githuboauth/secret
+        - --cookie-secret=/etc/cookie/secret
         - --plugin-config=/etc/plugins/plugins.yaml
         - --gcs-credentials-file=/etc/gcscredentials/service-account.json
         ports:

prow/templates/hook-deployment.yaml

@@ -34,7 +34,7 @@ spec:
         - --dry-run=false
         - --config-path=/etc/config/config.yaml
         - --github-endpoint=http://ghproxy
-#        - --github-endpoint=https://api.github.com
+        - --github-endpoint=https://api.github.com
         - --job-config-path=/etc/job-config
         ports:
           - name: http

prow/templates/hook-rbac.yaml

@@ -15,6 +15,8 @@ rules:
     verbs:
       - create
       - get
+      - list
+      - update
   - apiGroups:
       - ""
     resources:

prow/templates/needsrebase-deployment.yaml

@@ -23,7 +23,7 @@ spec:
         args:
         - --dry-run=false
         - --github-endpoint=http://ghproxy
-#        - --github-endpoint=https://api.github.com
+        - --github-endpoint=https://api.github.com
         ports:
           - name: http
             containerPort: 8888

prow/templates/plank-deployment.yaml

@@ -27,7 +27,7 @@ spec:
         - --config-path=/etc/config/config.yaml
         - --skip-report=true
         - --github-endpoint=http://ghproxy
-#        - --github-endpoint=https://api.github.com
+        - --github-endpoint=https://api.github.com
         - --job-config-path=/etc/job-config
         ports:
           - name: metrics

prow/templates/tide-deployment.yaml

@@ -25,7 +25,7 @@ spec:
         - --dry-run=false
         - --config-path=/etc/config/config.yaml
         - --github-endpoint=http://ghproxy
-#        - --github-endpoint=https://api.github.com
+        - --github-endpoint=https://api.github.com
         - --gcs-credentials-file=/etc/service-account/service-account.json
         - --history-uri=gs://{{ .Values.prowbucketname }}/tide-history.json
         - --status-path=gs://{{ .Values.prowbucketname }}/tide-status-checkpoint.yaml

prow/values.yaml

@@ -1,4 +1,3 @@
-prowjobNamespace: prow
 podNamespace: prow-test-pods
 
 prowbucketname: ouzidev-testinfra-252513-prow-artefacts
@@ -15,7 +14,7 @@ github:
     username: ouzibot
 
 hook:
-  image: gcr.io/k8s-prow/hook:v20200203-cae3cccf8
+  image: gcr.io/k8s-prow/hook:v20200427-baaf248ed
   replicas: 1
   ingress:
     host: prow.test-infra.ouzi.io
@@ -30,15 +29,15 @@ hook:
       effect: NoSchedule
 
 plank:
-  image: gcr.io/k8s-prow/plank:v20200203-cae3cccf8
+  image: gcr.io/k8s-prow/plank:v20200427-baaf248ed
   tolerations:
     - key: cloud.google.com/gke-preemptible
       operator: Equal
       value: "true"
       effect: NoSchedule
 
 sinker:
-  image: gcr.io/k8s-prow/sinker:v20200203-cae3cccf8
+  image: gcr.io/k8s-prow/sinker:v20200427-baaf248ed
   replicas: 1
   tolerations:
     - key: cloud.google.com/gke-preemptible
@@ -47,7 +46,7 @@ sinker:
       effect: NoSchedule
 
 deck:
-  image: gcr.io/k8s-prow/deck:v20200203-cae3cccf8
+  image: gcr.io/k8s-prow/deck:v20200427-baaf248ed
   replicas: 1
   ingress:
     host: prow.test-infra.ouzi.io
@@ -64,23 +63,23 @@ deck:
       effect: NoSchedule
 
 horologium:
-  image: gcr.io/k8s-prow/horologium:v20200203-cae3cccf8
+  image: gcr.io/k8s-prow/horologium:v20200427-baaf248ed
   tolerations:
     - key: cloud.google.com/gke-preemptible
       operator: Equal
       value: "true"
       effect: NoSchedule
 
 tide:
-  image: gcr.io/k8s-prow/tide:v20200203-cae3cccf8
+  image: gcr.io/k8s-prow/tide:v20200427-baaf248ed
   tolerations:
     - key: cloud.google.com/gke-preemptible
       operator: Equal
       value: "true"
       effect: NoSchedule
 
 statusreconciler:
-  image: gcr.io/k8s-prow/status-reconciler:v20200203-cae3cccf8
+  image: gcr.io/k8s-prow/status-reconciler:v20200427-baaf248ed
   replicas: 1
   tolerations:
     - key: cloud.google.com/gke-preemptible
@@ -89,15 +88,15 @@ statusreconciler:
       effect: NoSchedule
 
 needsrebase:
-  image: gcr.io/k8s-prow/needs-rebase:v20200203-cae3cccf8
+  image: gcr.io/k8s-prow/needs-rebase:v20200427-baaf248ed
   tolerations:
     - key: cloud.google.com/gke-preemptible
       operator: Equal
       value: "true"
       effect: NoSchedule
 
 branchprotector:
-  image: gcr.io/k8s-prow/branchprotector:v20200203-cae3cccf8
+  image: gcr.io/k8s-prow/branchprotector:v20200427-baaf248ed
   schedule: 12 * * * * # Every hour at 12 minutes past the hour
   tolerations:
     - key: cloud.google.com/gke-preemptible
@@ -106,7 +105,7 @@ branchprotector:
       effect: NoSchedule
 
 crier:
-  image: gcr.io/k8s-prow/crier:v20200203-cae3cccf8
+  image: gcr.io/k8s-prow/crier:v20200427-baaf248ed
   replicas: 1
   tolerations:
     - key: cloud.google.com/gke-preemptible
@@ -115,7 +114,7 @@ crier:
       effect: NoSchedule
 
 labelsync:
-  image: gcr.io/k8s-prow/label_sync:v20200203-cae3cccf8
+  image: gcr.io/k8s-prow/label_sync:v20200427-baaf248ed
   schedule: 0 5 * * * # Every day at 5AM
   tolerations:
     - key: cloud.google.com/gke-preemptible
@@ -126,8 +125,8 @@ labelsync:
 # requires tekton to work - 
 # we will install it part of the chart in a later revision
 pipeline:
-  # image: gcr.io/k8s-prow/pipeline:v20200203-cae3cccf8
-  image: gcr.io/k8s-prow/pipeline:v20200203-cae3cccf8
+  # image: gcr.io/k8s-prow/pipeline:v20200427-baaf248ed
+  image: gcr.io/k8s-prow/pipeline:v20200427-baaf248ed
   tolerations:
     - key: cloud.google.com/gke-preemptible
       operator: Equal
@@ -152,7 +151,7 @@ pushgateway:
         effect: NoSchedule
 
 ghproxy:
-  image: gcr.io/k8s-prow/ghproxy:v20200203-cae3cccf8
+  image: gcr.io/k8s-prow/ghproxy:v20200427-baaf248ed
   replicas: 1
   cache:
     sizeGB: 19