TypeError: Cannot close a writable stream that is closed or errored

[huseeiin]

How can we reproduce the crash?

this is a compiled solid-js streaming ssr app:

import { renderToStream, ssr, ssrHydrationKey } from "solid-js/web";
var _tmpl$ = ["<h1", ">Home</h1>"];
function App() {
  return ssr(_tmpl$, ssrHydrationKey());
}
Bun.serve({
  fetch(req) {
    const {
      readable,
      writable
    } = new TransformStream();
    renderToStream(App).pipeTo(writable);
    return new Response(readable);
  }
});

this only happens when a request is aborted before the stream finishes. best way to reproduce it is running a benchmark and pressing ctrl+c to close it before it finishes.

this also happens in node:http:

error: Stream is already ended
code: "ERR_STREAM_ALREADY_FINISHED"

Stack Trace (bun.report)

Bun v1.2.6-canary (ba7f593) on linux x86_64 [AutoCommand]

Segmentation fault at address 0x02A6E820

• memory_allocator.zig:31: bun.js.api.server.NewRequestContext
• server.zig:2716: deps.uws.NewApp
• HttpContext.h:129: uWS::HttpContext<false>::init(...)::__invoke
• socket.c:218: us_socket_close
• loop.c:448: us_loop_run_bun_tick
• event_loop.zig:0: bun.js.event_loop.EventLoop.autoTickActive
• bun_js.zig:396: bun.js.javascript.OpaqueWrap__anon_35661__struct_242800.callback
• bindings.cpp:5182: JSC__VM__holdAPILock

Features: tsconfig, tsconfig_paths, abort_signal, http_server, jsc

_{Sentry Issue: BUN-EAX}

[Jarred-Sumner]

I'm pretty sure the underlying crash here was fixed a little while ago (missing exception checks), but not propagating the storedError is fixed in #20851

[icarofr]

Can confirm the bug is still up on the version v1.2.24-canary.106+420d51985 and v1.2.23.

paris-spurs-client  | TypeError: Cannot close a writable stream that is closed or errored
paris-spurs-client  |       at end (/app/.output/server/node_modules/solid-js/web/dist/server.js:412:17)
paris-spurs-client  |       at onDone (/app/.output/server/node_modules/solid-js/web/dist/server.js:246:26)
paris-spurs-client  |       at flush (/app/.output/server/node_modules/seroval/dist/esm/production/index.mjs:17:38978)
paris-spurs-client  | 
paris-spurs-client  | Bun v1.2.24-canary.106+420d51985 (Linux x64 baseline)
paris-spurs-client  | Listening on http://localhost:3000/...
paris-spurs-client  | error: undefined
paris-spurs-client  | undefined

No changes to entry-server were done.

[jaroel]

The problem does indeed go away when I use the binary made with bunx bun-pr 20851 when running benchmarks on solid-start.

My guess is that #20851 was unintentionally closed without merging; maybe this could be revisited?

[jaroel]

I ran into this while benchmarking solid-start. With bun 1.3.3+274e01c73 that specific issue no longer seems to happen.

Huseeiin's example does still error:

 code: "ERR_STREAM_WRITE_AFTER_END"

      at hasServerResponseFinished (internal:http:204:33)
      at <anonymous> (node:_http_server:820:32)
      at write (/Users/roel/Develop/work/dfm/solid-site/node_modules/h3/dist/index.mjs:867:26)
199 |   let finished = self.finished;
200 |   if (chunk) {
201 |     let destroyed = self.destroyed;
202 |     if (finished || destroyed) {
203 |       let err;
204 |         err = @makeErrorWithCode(236);```

[huseeiin]

will be fixed by ryansolid/dom-expressions#477