fix: block same account transfers (#54)

Author: Ehbw

locales/en.json

@@ -161,5 +161,6 @@
   "no_balance": "No balance",
   "no_access": "No access",
   "something_went_wrong": "Unknown error, something went wrong",
-  "account_id_not_exists": "No account with such id found"
+  "account_id_not_exists": "No account with such id found",
+  "same_account_transfer": "Cannot transfer money to the same account"
 }

src/server/index.ts

@@ -137,6 +137,7 @@ onClientCallback(
 
     if (!hasPermission) return;
 
+    target = typeof(target) == "string" ? Number.parseInt(target) : target
     let targetAccountId = 0;
 
     try {

src/web/src/layouts/bank/pages/accounts/modals/TransferModal.tsx

@@ -64,6 +64,12 @@ const TransferModal: React.FC<{ account: Account }> = ({ account }) => {
         message: locales.amount_greater_than_balance,
       });
 
+    if (values.transferType == 'account' && account.id == values.target)
+      return form.setError('target', {
+        type: 'value',
+        message: locales.same_account_transfer
+      })
+
     setIsLoading(true);
     const resp = await fetchNui<{ success: boolean; message?: string }>(
       'transferMoney',