Remove deprecated pkg_resources.parse_version

Author: overfl0

tools/build.py

@@ -1,6 +1,7 @@
 # /// script
 # dependencies = [
 #   "auditwheel < 5",
+#   "packaging",
 #   "pefile",
 #   "pyelftools",  # elftools
 #   "setuptools < 74",
@@ -15,27 +16,12 @@
 import sys
 from datetime import datetime
 
+import packaging.version
 import setuptools.msvc
-from pkg_resources import parse_version
 
 os.chdir(os.path.dirname(os.path.dirname(os.path.realpath(__file__))))
 
 
-# Python 3.7 workaround:
-def parse_version_wrapper(txt):
-    version = parse_version(txt)
-
-    try:
-        version.major  # noqa
-        version.minor  # noqa
-    except AttributeError:
-        # Python 3.7 doesn't have these so we patch them in
-        version.major = version._version.release[0]
-        version.minor = version._version.release[1]
-
-    return version
-
-
 def _run(cmd, **kwargs):
     # For some reason, when combined with wsl calls, Python thinks the directory we're in has been deleted
     # so os.getcwd() fails
@@ -75,7 +61,7 @@ def del_rw(action, name, exc):
 
 
 def create_interpreters(version, dest):
-    version = parse_version_wrapper(version)
+    version = packaging.version.Version(version)
     print(f'Creating Python {version} interpreters in "{dest}" directory...', flush=True)
     _run([sys.executable, os.path.join('tools', 'create_embedded_python.py'), '--version', str(version), dest], check=True)
 
@@ -95,7 +81,7 @@ def _get_embed(version, system, arch):
 
 
 def build_binaries(version, arch, system, run_tests=True):
-    version = parse_version_wrapper(version)
+    version = packaging.version.Version(version)
     print(f'Building {arch} binaries for {system}...', flush=True)
 
     if system == 'linux':
@@ -128,7 +114,7 @@ def build_binaries(version, arch, system, run_tests=True):
 
 
 def run_tests(version, arch, system):
-    version = parse_version_wrapper(version)
+    version = packaging.version.Version(version)
     print(f'Running tests for {arch} {system}...', flush=True)
 
     _verbose_run([_get_embed(version, system, arch), os.path.join('tests', 'tests.py')], check=True)
@@ -140,7 +126,7 @@ def build_pbos():
 
 
 def copy_templates(version):
-    version = parse_version_wrapper(version)
+    version = packaging.version.Version(version)
     print('Copying files to @Pythia folder...', flush=True)
 
     for f in os.listdir('templates'):
@@ -157,7 +143,7 @@ def copy_templates(version):
 
 
 def safety_checks(version):
-    version = parse_version_wrapper(version)
+    version = packaging.version.Version(version)
     print('Running safety checks...', flush=True)
     _run([sys.executable, os.path.join('tools', 'safety_checks.py'), str(version)], check=True)
 

tools/rebuild_all.py

@@ -1,8 +1,9 @@
 # /// script
 # dependencies = [
 #   "auditwheel < 5",
+#   "packaging",
 #   "pefile",
-#   "pyelftools",
+#   "pyelftools",  # elftools
 #   "setuptools < 74",
 # ]
 # ///

tools/safety_checks.py

@@ -1,6 +1,7 @@
 # /// script
 # dependencies = [
 #   "auditwheel < 5",
+#   "packaging",
 #   "pefile",
 #   "pyelftools",  # elftools
 #   "setuptools < 74",
@@ -12,7 +13,7 @@
 import sys
 from typing import List
 
-from pkg_resources import parse_version
+import packaging.version
 
 
 def check_dll_architecture(path: str, x86=False):
@@ -117,10 +118,10 @@ def check_so_is_manylinux2014(path: str, allowed_imports: List = None):
     }
 
     allowed_symbol_versions = {
-        'GLIBC': parse_version('2.17'),
-        'CXXABI': parse_version('1.3.7'),
-        'GLIBCXX': parse_version('3.4.19'),
-        'GCC': parse_version('4.8.0'),
+        'GLIBC': packaging.version.Version('2.17'),
+        'CXXABI': packaging.version.Version('1.3.7'),
+        'GLIBCXX': packaging.version.Version('3.4.19'),
+        'GCC': packaging.version.Version('4.8.0'),
     }
 
     allowed_imports_lower = {'ld-linux.so.2', 'ld-linux-x86-64.so.2'}
@@ -157,7 +158,7 @@ def check_so_is_manylinux2014(path: str, allowed_imports: List = None):
         elffile = ELFFile(file)
         for filename, symbol in elf_find_versioned_symbols(elffile):
             symbol_name, _, version = symbol.partition('_')
-            if parse_version(version) > allowed_symbol_versions[symbol_name]:
+            if packaging.version.Version(version) > allowed_symbol_versions[symbol_name]:
                 print(f'There is a call to {symbol_name} at version {version} which is not allowed for manylinux2014. '
                       'Rebuild the code using the manylinux2014 docker image!')
                 sys.exit(1)