Skip to content

Mounted MFEs with node_modules missing fail to start the server #218

@DawoudSheraz

Description

@DawoudSheraz

This issue is a similar issue to overhangio/tutor#997. The steps to reproduce are:

  • Installed latest tutor master or nightly
  • Clone any MFE repo (authn, learner-dashboard, etc.) and check out its appropriate branch (open-release/redwood.master if latest tutor master, master if tutor nightly)
  • Add the cloned MFE as a bind mount
  • Re-build mfe-dev images
  • Run platform. Verify the mounted-MFE container runs into the error fedx-script not found
  • Run npm install within cloned MFE repo on the host. Once installed, MFE dev container should be up and running.

Like the mentioned issue in tutor core, the bind-mounted MFE during image build does not get node_modules copied back to host. When running tutor, the host MFE directory without node_modules overrides the installed node_modules within image, thus resulting in fedx-script not found.

  • Add a similar fix as core issue i.e. if node_modules are not found in MFE directory, run npm clean-install to install the required dependencies
    • If there is another fix, feel free to suggest it.

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

Status

Blocked

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions