fix: update content when ready, fix cannot drag to new window (#270)

- fix: return 0 directly when diagnostics is empty

- fix: update content when ready, fix cannot drag to new window

- fix: dispose onDidChange listener when webview is disposed

Author: zeyugao

src/core/pdfViewEditorProvider.ts

@@ -58,13 +58,23 @@ export class PdfViewEditorProvider implements vscode.CustomEditorProvider<PdfDoc
 
     public async resolveCustomEditor(doc: PdfDocument, webviewPanel: vscode.WebviewPanel): Promise<void> {
         EventBus.fire('pdfWillOpenEvent', {uri: doc.uri, doc, webviewPanel});
-        doc.onDidChange(() => {
-            webviewPanel.webview.postMessage({type:'update', content:doc.cache.buffer});
+
+        const updateWebview = () => {
+            if (doc.cache.buffer.byteLength !== 0) {
+                webviewPanel.webview.postMessage({type:'update', content:doc.cache.buffer});
+            }
+        }
+
+        const docOnDidChangeListener = doc.onDidChange(() => {
+            updateWebview();
+        });
+
+        webviewPanel.onDidDispose(() => {
+            docOnDidChangeListener.dispose();
         });
 
         webviewPanel.webview.options = {enableScripts:true};
         webviewPanel.webview.html = await this.getHtmlForWebview(webviewPanel.webview);
-        webviewPanel.webview.postMessage({type:'update', content:doc.cache.buffer});
 
         // register event listeners
         webviewPanel.onDidChangeViewState((e) => {
@@ -84,6 +94,7 @@ export class PdfViewEditorProvider implements vscode.CustomEditorProvider<PdfDoc
                     const state = GlobalStateManager.getPdfViewPersist(this.context, doc.uri.toString());
                     const colorThemes = vscode.workspace.getConfiguration('overleaf-workshop.pdfViewer').get('themes', undefined);
                     webviewPanel.webview.postMessage({type:'initState', content:state, colorThemes});
+                    updateWebview();
                     break;
                 default:
                     break;

src/intellisense/langMisspellingCheckProvider.ts

@@ -105,6 +105,10 @@ export class MisspellingCheckProvider extends IntellisenseProvider implements vs
     }
 
     provideCodeActions(document: vscode.TextDocument, range: vscode.Range, context: vscode.CodeActionContext, token: vscode.CancellationToken): vscode.ProviderResult<vscode.CodeAction[]> {
+        if (context.diagnostics.length === 0) {
+            return [];
+        }
+
         const diagnostic = context.diagnostics[0];
         const actions = this.suggestionCache.get(diagnostic.code as string)
                         ?.slice(0,8).map(suggestion => {