allow file upload without filename

Author: Ersun Warncke

lib/make-middleware.js

@@ -112,8 +112,10 @@ function makeMiddleware (setup) {
 
       if (fieldname == null) return abortWithCode('MISSING_FIELD_NAME')
 
-      // don't attach to the files object, if there is no file
-      if (!filename) return fileStream.resume()
+      // filename is not required (https://tools.ietf.org/html/rfc1867) but if
+      // filename not present busboy only treats as file if content type is
+      // application/octet-stream
+      if (!filename) filename = 'undefined'
 
       // Work around bug in Busboy (https://github.com/mscdex/busboy/issues/6)
       if (limits && Object.prototype.hasOwnProperty.call(limits, 'fieldNameSize')) {

test/files/no-filename.dat

@@ -0,0 +1,11 @@
+--99999
+Content-Disposition: form-data; name="textField"
+Content-Type: text/plain; charset=ISO-8859-1
+
+foo
+--99999
+Content-Disposition: form-data; name="fileField"
+Content-Type: application/octet-stream
+
+foo
+--99999--

test/no-filename.js

@@ -0,0 +1,37 @@
+/* eslint-env mocha */
+
+var assert = require('assert')
+var fs = require('fs')
+var onFinished = require('on-finished')
+var path = require('path')
+
+var multer = require('../')
+
+describe('File with no filename', function () {
+  var upload
+
+  before(function () {
+    upload = multer()
+  })
+
+  it('should accept file without filename', function (done) {
+    var parser = upload.any()
+
+    var filePath = path.join(__dirname, 'files', 'no-filename.dat')
+    var req = fs.createReadStream(filePath)
+    req.headers = {
+      'content-type': 'multipart/form-data; boundary=99999',
+      'content-length': fs.statSync(filePath).size
+    }
+
+    parser(req, null, function (err) {
+      onFinished(req, function () {
+        assert.ifError(err)
+        assert.equal(req.files.length, 1)
+        assert.equal(req.files[0].fieldname, 'fileField')
+        assert.equal(req.files[0].buffer.toString(), 'foo')
+        done()
+      })
+    })
+  })
+})