This repository was archived by the owner on Dec 5, 2025. It is now read-only.
feat:新增指标上报 #2
Merged
feat:新增指标上报 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overtrue
reviewed
Sep 8, 2025
src/Support/Metric.php
Outdated
| } | ||
| } | ||
|
|
||
| public function createCounter(string $name, ?string $unit = null, |
Owner
There was a problem hiding this comment.
这几个 createXXX 我希望改成 laravel style, 就是直接 Metric::counter() Metric::histogram
overtrue
reviewed
Sep 8, 2025
src/Support/Metric.php
Outdated
| } | ||
|
|
||
| public function createHistogram(string $name, ?string $unit = null, | ||
| ?string $description = null, array $advisory = []): HistogramInterface |
added 2 commits
September 8, 2025 10:29
overtrue
approved these changes
Sep 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新增Metric指标上报