Skip to content

Commit 08e8c21

Browse files
committed
web: don't clutter up web console by default
If one wishes to add debug output, they should use overviewer.utils.debug. To see the output produced by that, set overviewerConfig.map.debug to true. Fixes #1816.
1 parent 11aabbf commit 08e8c21

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

overviewer_core/assetmanager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ def get_data(tileset):
124124

125125
dump['worlds'] = worlds
126126
dump['map'] = dict()
127-
dump['map']['debug'] = True
127+
dump['map']['debug'] = False
128128
dump['map']['cacheTag'] = str(int(time.time()))
129129
dump['map']['north_direction'] = 'lower-left' # only temporary
130130
dump['map']['controls'] = {

overviewer_core/data/js_src/util.js

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,8 @@ overviewer.util = {
136136
this.select.appendChild(option);
137137
},
138138
onChange: function(ev) {
139-
console.log(ev.target);
140-
console.log(ev.target.value);
139+
overviewer.util.debug(ev.target);
140+
overviewer.util.debug(ev.target.value);
141141
var selected_world = ev.target.value;
142142

143143

@@ -204,8 +204,6 @@ overviewer.util = {
204204
overviewer.map.addLayer(overviewer.collections.mapTypes[selected_world][selected_layer_name]);
205205
},
206206
onAdd: function() {
207-
console.log("onAdd mycontrol");
208-
209207
return this.container
210208
}
211209
});
@@ -290,7 +288,7 @@ overviewer.util = {
290288

291289
// reset the markers control with the markers for this layer
292290
if (ovconf.marker_groups) {
293-
console.log("markers for", ovconf.marker_groups);
291+
overviewer.util.debug("markers for", ovconf.marker_groups);
294292
ovconf.markerCtrl = L.control.layers(
295293
[],
296294
ovconf.marker_groups, {collapsed: false}).addTo(overviewer.map);
@@ -376,7 +374,7 @@ overviewer.util = {
376374
if (overviewer.collections.haveSigns == true) {
377375
// if there are markers for this tileset, create them now
378376
if ((typeof markers !== 'undefined') && (obj.path in markers)) {
379-
console.log("this tileset has markers:", obj);
377+
overviewer.util.debug("this tileset has markers:", obj);
380378
obj.marker_groups = {};
381379

382380
// For every group of markers
@@ -538,9 +536,9 @@ overviewer.util = {
538536
*
539537
* @param string msg
540538
*/
541-
'debug': function(msg) {
539+
'debug': function(...args) {
542540
if (overviewerConfig.map.debug) {
543-
console.log(msg);
541+
console.log(...args);
544542
}
545543
},
546544
/**

0 commit comments

Comments
 (0)