fix(account-creation): fix crashe in settings page

ref: #MANAGER-20305

Signed-off-by: achraf hafedh <[email protected]>

Author: achraf hafedh

packages/manager/apps/account-creation/src/pages/settings/settings.page.tsx

@@ -237,7 +237,7 @@ export default function Settings() {
                 isDisabled={!languages?.length}
                 onOdsChange={onChange}
                 onBlur={onBlur}
-                key={`languages_for_${selectedCountry}`}
+                key={`languages_for_${selectedCountry}_${selectedCurrency}`}
                 hasError={Boolean(languages?.length && errors[name])}
                 data-testid="language-select"
               >

packages/manager/apps/account-creation/src/pages/settings/settings.spec.tsx

@@ -116,9 +116,8 @@ describe('SettingsPage', () => {
       await setInputhValue(currencySelectElement, 'EUR');
     });
 
-    const languageSelectElement = screen.getByTestId('language-select');
-
     await waitFor(() => {
+      const languageSelectElement = screen.getByTestId('language-select');
       expect(languageSelectElement.getAttribute('is-disabled')).not.toBe(
         'true',
       );
@@ -134,10 +133,9 @@ describe('SettingsPage', () => {
       await setInputhValue(countryComboboxElement, 'GB');
     });
 
-    const currencySelectElement = screen.getByTestId('currency-select');
-    const languageSelectElement = screen.getByTestId('language-select');
-
     await waitFor(() => {
+      const currencySelectElement = screen.getByTestId('currency-select');
+      const languageSelectElement = screen.getByTestId('language-select');
       expect(currencySelectElement.getAttribute('value')).toBe('GBP');
       expect(languageSelectElement.getAttribute('value')).toBe('en-GB');
     });