fix: Use the right kind of public cloud loadbalancer

amstuta · amstuta · commit 9b126429a78f · 2025-10-14T12:10:22.000Z
Signed-off-by: Arthur Amstutz &lt;arthur.amstutz@corp.ovh.com&gt;
diff --git a/doc/ovhcloud_cloud_loadbalancer_edit.md b/doc/ovhcloud_cloud_loadbalancer_edit.md
@@ -11,9 +11,9 @@ ovhcloud cloud loadbalancer edit <loadbalancer_id> [flags]
 ```
       --description string   Description of the loadbalancer
       --editor               Use a text editor to define parameters
+      --flavor string        Flavor ID of the loadbalancer (can be retrieved with 'cloud reference loadbalancer list-flavors <region>')
   -h, --help                 help for edit
       --name string          Name of the loadbalancer
-      --size string          Size of the load balancer (S, M, L)
 ```
 
 ### Options inherited from parent commands
diff --git a/doc/ovhcloud_cloud_reference.md b/doc/ovhcloud_cloud_reference.md
@@ -34,5 +34,6 @@ Fetch reference data in the given cloud project
 * [ovhcloud cloud reference database](ovhcloud_cloud_reference_database.md)	 - Fetch database reference data in the given cloud project
 * [ovhcloud cloud reference list-flavors](ovhcloud_cloud_reference_list-flavors.md)	 - List available flavors in the given cloud project
 * [ovhcloud cloud reference list-images](ovhcloud_cloud_reference_list-images.md)	 - List available images in the given cloud project
+* [ovhcloud cloud reference loadbalancer](ovhcloud_cloud_reference_loadbalancer.md)	 - Fetch loadbalancer reference data in the given cloud project
 * [ovhcloud cloud reference rancher](ovhcloud_cloud_reference_rancher.md)	 - Fetch Rancher reference data in the given cloud project
 
diff --git a/doc/ovhcloud_cloud_reference_loadbalancer.md b/doc/ovhcloud_cloud_reference_loadbalancer.md
@@ -0,0 +1,34 @@
+## ovhcloud cloud reference loadbalancer
+
+Fetch loadbalancer reference data in the given cloud project
+
+### Options
+
+```
+  -h, --help   help for loadbalancer
+```
+
+### Options inherited from parent commands
+
+```
+      --cloud-project string   Cloud project ID
+  -d, --debug                  Activate debug mode (will log all HTTP requests details)
+  -f, --format string          Output value according to given format (expression using https://github.com/PaesslerAG/gval syntax)
+                               Examples:
+                                 --format 'id' (to extract a single field)
+                                 --format 'nested.field.subfield' (to extract a nested field)
+                                 --format '[id, 'name']' (to extract multiple fields as an array)
+                                 --format '{"newKey": oldKey, "otherKey": nested.field}' (to extract and rename fields in an object)
+                                 --format 'name+","+type' (to extract and concatenate fields in a string)
+                                 --format '(nbFieldA + nbFieldB) * 10' (to compute values from numeric fields)
+  -e, --ignore-errors          Ignore errors in API calls when it is not fatal to the execution
+  -i, --interactive            Interactive output
+  -j, --json                   Output in JSON
+  -y, --yaml                   Output in YAML
+```
+
+### SEE ALSO
+
+* [ovhcloud cloud reference](ovhcloud_cloud_reference.md)	 - Fetch reference data in the given cloud project
+* [ovhcloud cloud reference loadbalancer list-flavors](ovhcloud_cloud_reference_loadbalancer_list-flavors.md)	 - List available loadbalancer flavors in the given cloud project
+
diff --git a/doc/ovhcloud_cloud_reference_loadbalancer_list-flavors.md b/doc/ovhcloud_cloud_reference_loadbalancer_list-flavors.md
@@ -0,0 +1,44 @@
+## ovhcloud cloud reference loadbalancer list-flavors
+
+List available loadbalancer flavors in the given cloud project
+
+```
+ovhcloud cloud reference loadbalancer list-flavors <region (GRA9, BHS5, ...)> [flags]
+```
+
+### Options
+
+```
+      --filter stringArray   Filter results by any property using https://github.com/PaesslerAG/gval syntax
+                             Examples:
+                               --filter 'state="running"'
+                               --filter 'name=~"^my.*"'
+                               --filter 'nested.property.subproperty>10'
+                               --filter 'startDate>="2023-12-01"'
+                               --filter 'name=~"something" && nbField>10'
+  -h, --help                 help for list-flavors
+```
+
+### Options inherited from parent commands
+
+```
+      --cloud-project string   Cloud project ID
+  -d, --debug                  Activate debug mode (will log all HTTP requests details)
+  -f, --format string          Output value according to given format (expression using https://github.com/PaesslerAG/gval syntax)
+                               Examples:
+                                 --format 'id' (to extract a single field)
+                                 --format 'nested.field.subfield' (to extract a nested field)
+                                 --format '[id, 'name']' (to extract multiple fields as an array)
+                                 --format '{"newKey": oldKey, "otherKey": nested.field}' (to extract and rename fields in an object)
+                                 --format 'name+","+type' (to extract and concatenate fields in a string)
+                                 --format '(nbFieldA + nbFieldB) * 10' (to compute values from numeric fields)
+  -e, --ignore-errors          Ignore errors in API calls when it is not fatal to the execution
+  -i, --interactive            Interactive output
+  -j, --json                   Output in JSON
+  -y, --yaml                   Output in YAML
+```
+
+### SEE ALSO
+
+* [ovhcloud cloud reference loadbalancer](ovhcloud_cloud_reference_loadbalancer.md)	 - Fetch loadbalancer reference data in the given cloud project
+
diff --git a/internal/cmd/cloud_loadbalancer.go b/internal/cmd/cloud_loadbalancer.go
@@ -37,9 +37,9 @@ func initCloudLoadbalancerCommand(cloudCmd *cobra.Command) {
 		Run:   cloud.EditCloudLoadbalancer,
 		Args:  cobra.ExactArgs(1),
 	}
-	editLoadbalancerCmd.Flags().StringVar(&cloud.CloudLoadbalancerUpdateFields.Name, "name", "", "Name of the loadbalancer")
-	editLoadbalancerCmd.Flags().StringVar(&cloud.CloudLoadbalancerUpdateFields.Description, "description", "", "Description of the loadbalancer")
-	editLoadbalancerCmd.Flags().StringVar(&cloud.CloudLoadbalancerUpdateFields.Size, "size", "", "Size of the load balancer (S, M, L)")
+	editLoadbalancerCmd.Flags().StringVar(&cloud.CloudLoadbalancerUpdateSpec.Name, "name", "", "Name of the loadbalancer")
+	editLoadbalancerCmd.Flags().StringVar(&cloud.CloudLoadbalancerUpdateSpec.Description, "description", "", "Description of the loadbalancer")
+	editLoadbalancerCmd.Flags().StringVar(&cloud.CloudLoadbalancerUpdateSpec.FlavorId, "flavor", "", "Flavor ID of the loadbalancer (can be retrieved with 'cloud reference loadbalancer list-flavors <region>')")
 	addInteractiveEditorFlag(editLoadbalancerCmd)
 	loadbalancerCmd.AddCommand(editLoadbalancerCmd)
 
diff --git a/internal/cmd/cloud_loadbalancer_test.go b/internal/cmd/cloud_loadbalancer_test.go
@@ -0,0 +1,109 @@
+// SPDX-FileCopyrightText: 2025 OVH SAS <opensource@ovh.net>
+//
+// SPDX-License-Identifier: Apache-2.0
+
+package cmd_test
+
+import (
+	"net/http"
+
+	"github.com/jarcoal/httpmock"
+	"github.com/maxatome/go-testdeep/td"
+	"github.com/ovh/ovhcloud-cli/internal/cmd"
+)
+
+func (ms *MockSuite) TestCloudLoadbalancerGetCmd(assert, require *td.T) {
+	httpmock.RegisterResponder(http.MethodGet, "https://eu.api.ovh.com/1.0/cloud/project/fakeProjectID/region",
+		httpmock.NewStringResponder(200, `["GRA11", "SBG5", "BHS5"]`))
+
+	httpmock.RegisterResponder(http.MethodGet, "https://eu.api.ovh.com/1.0/cloud/project/fakeProjectID/region/GRA11",
+		httpmock.NewStringResponder(200, `{
+			"name": "GRA11",
+			"type": "region",
+			"status": "UP",
+			"services": [
+				{
+					"name": "octavialoadbalancer",
+					"status": "UP"
+				}
+			],
+			"countryCode": "fr",
+			"ipCountries": [],
+			"continentCode": "NA",
+			"availabilityZones": [],
+			"datacenterLocation": "GRA11"
+		}`))
+
+	httpmock.RegisterResponder(http.MethodGet, "https://eu.api.ovh.com/1.0/cloud/project/fakeProjectID/region/SBG5",
+		httpmock.NewStringResponder(200, `{
+			"name": "SBG5",
+			"type": "region",
+			"status": "UP",
+			"services": [
+				{
+					"name": "octavialoadbalancer",
+					"status": "UP"
+				}
+			],
+			"countryCode": "fr",
+			"ipCountries": [],
+			"continentCode": "NA",
+			"availabilityZones": [],
+			"datacenterLocation": "SBG5"
+		}`))
+
+	httpmock.RegisterResponder(http.MethodGet, "https://eu.api.ovh.com/1.0/cloud/project/fakeProjectID/region/BHS5",
+		httpmock.NewStringResponder(200, `{
+			"name": "BHS5",
+			"type": "region",
+			"status": "UP",
+			"services": [],
+			"countryCode": "ca",
+			"ipCountries": [],
+			"continentCode": "NA",
+			"availabilityZones": [],
+			"datacenterLocation": "BHS5"
+		}`))
+
+	httpmock.RegisterResponder(http.MethodGet,
+		"https://eu.api.ovh.com/1.0/cloud/project/fakeProjectID/region/SBG5/loadbalancing/loadbalancer/fakeLB",
+		httpmock.NewStringResponder(200, `{
+			"createdAt": "2024-07-30T08:26:51Z",
+			"flavorId": "f862fa22-6275-4f8f-885e-66a8faf5e44e",
+			"floatingIp": null,
+			"id": "334fc97e-a8db-11f0-944d-0050568ce122",
+			"name": "loadbalancer-sbg5-2024-07-30",
+			"operatingStatus": "online",
+			"provisioningStatus": "active",
+			"region": "SBG5",
+			"updatedAt": "2025-10-14T08:48:33Z",
+			"vipAddress": "1.2.3.4",
+			"vipNetworkId": "3f29f530-a8db-11f0-9ab2-0050568ce122",
+			"vipSubnetId": "44a869c4-a8db-11f0-899f-0050568ce122"
+		}`))
+
+	out, err := cmd.Execute("cloud", "loadbalancer", "get", "fakeLB", "--cloud-project", "fakeProjectID")
+	require.CmpNoError(err)
+	assert.Cmp(cleanWhitespacesHelper(out), `
+  # 🚀 Load balancer fakeLB
+
+  *loadbalancer-sbg5-2024-07-30*
+
+  ## General information
+
+  **Region**:              SBG5
+  **Operating status**:    online
+  **Provisioning status**: active
+  **Flavor ID**:           f862fa22-6275-4f8f-885e-66a8faf5e44e
+  **Creation date**:       2024-07-30T08:26:51Z
+
+  ## Technical information
+
+  **VIP address**:        1.2.3.4
+  **VIP network ID**:     3f29f530-a8db-11f0-9ab2-0050568ce122
+  **VIP subnet ID**:      44a869c4-a8db-11f0-899f-0050568ce122
+
+  💡 Use option --json or --yaml to get the raw output with all information
+
+`)
+}
diff --git a/internal/cmd/cloud_reference.go b/internal/cmd/cloud_reference.go
@@ -111,5 +111,19 @@ func initCloudReferenceCmd(cloudCmd *cobra.Command) {
 		Args:  cobra.NoArgs,
 	}))
 
+	// Loadbalancer reference commands
+	loadbalancerReferenceCmd := &cobra.Command{
+		Use:   "loadbalancer",
+		Short: "Fetch loadbalancer reference data in the given cloud project",
+	}
+	referenceCmd.AddCommand(loadbalancerReferenceCmd)
+
+	loadbalancerReferenceCmd.AddCommand(withFilterFlag(&cobra.Command{
+		Use:   "list-flavors <region (GRA9, BHS5, ...)>",
+		Short: "List available loadbalancer flavors in the given cloud project",
+		Run:   cloud.ListLoadbalancerFlavors,
+		Args:  cobra.ExactArgs(1),
+	}))
+
 	cloudCmd.AddCommand(referenceCmd)
 }
diff --git a/internal/cmd/cmd_test.go b/internal/cmd/cmd_test.go
@@ -6,6 +6,7 @@ package cmd_test
 
 import (
 	"os"
+	"regexp"
 	"testing"
 
 	"github.com/jarcoal/httpmock"
@@ -75,3 +76,7 @@ func resetSubCommandFlagValues(root *cobra.Command) {
 		resetSubCommandFlagValues(c)
 	}
 }
+
+func cleanWhitespacesHelper(s string) string {
+	return regexp.MustCompile(` +\n`).ReplaceAllString(s, "\n")
+}
diff --git a/internal/services/cloud/cloud_loadbalancer.go b/internal/services/cloud/cloud_loadbalancer.go
@@ -11,32 +11,83 @@ import (
 
 	"github.com/ovh/ovhcloud-cli/internal/assets"
 	"github.com/ovh/ovhcloud-cli/internal/display"
+	filtersLib "github.com/ovh/ovhcloud-cli/internal/filters"
 	"github.com/ovh/ovhcloud-cli/internal/flags"
+	httpLib "github.com/ovh/ovhcloud-cli/internal/http"
 	"github.com/ovh/ovhcloud-cli/internal/services/common"
 	"github.com/spf13/cobra"
 )
 
 var (
-	cloudprojectLoadbalancerColumnsToDisplay = []string{"id", "openstackRegion", "size", "status"}
+	cloudprojectLoadbalancerColumnsToDisplay = []string{"id", "name", "region", "provisioningStatus", "operatingStatus"}
 
 	//go:embed templates/cloud_loadbalancer.tmpl
 	cloudLoadbalancerTemplate string
 
-	CloudLoadbalancerUpdateFields struct {
+	CloudLoadbalancerUpdateSpec struct {
 		Description string `json:"description,omitempty"`
 		Name        string `json:"name,omitempty"`
-		Size        string `json:"size,omitempty"`
+		FlavorId    string `json:"flavorId,omitempty"`
 	}
 )
 
+func locateLoadbalancer(projectID, loadbalancerID string) (string, map[string]any, error) {
+	// Fetch regions with loadbalancer feature available
+	regions, err := getCloudRegionsWithFeatureAvailable(projectID, "octavialoadbalancer")
+	if err != nil {
+		return "", nil, fmt.Errorf("failed to fetch regions with loadbalancer feature available: %w", err)
+	}
+
+	// Search for the given loadbalancer in all regions
+	for _, region := range regions {
+		endpoint := fmt.Sprintf("/cloud/project/%s/region/%s/loadbalancing/loadbalancer/%s",
+			projectID, url.PathEscape(region.(string)), url.PathEscape(loadbalancerID))
+
+		var loadbalancer map[string]any
+		if err := httpLib.Client.Get(endpoint, &loadbalancer); err == nil {
+			return region.(string), loadbalancer, nil
+		}
+	}
+
+	return "", nil, fmt.Errorf("no loadbalancer found with id %s", loadbalancerID)
+}
+
 func ListCloudLoadbalancers(_ *cobra.Command, _ []string) {
 	projectID, err := getConfiguredCloudProject()
 	if err != nil {
 		display.OutputError(&flags.OutputFormatConfig, "%s", err)
 		return
 	}
 
-	common.ManageListRequest(fmt.Sprintf("/cloud/project/%s/loadbalancer", projectID), "", cloudprojectLoadbalancerColumnsToDisplay, flags.GenericFilters)
+	// Fetch regions with loadbalancer feature available
+	regions, err := getCloudRegionsWithFeatureAvailable(projectID, "octavialoadbalancer")
+	if err != nil {
+		display.OutputError(&flags.OutputFormatConfig, "failed to fetch regions with loadbalancer feature available: %s", err)
+		return
+	}
+
+	// Fetch loadbalancers in all regions
+	endpoint := fmt.Sprintf("/cloud/project/%s/region", projectID)
+	containers, err := httpLib.FetchObjectsParallel[[]map[string]any](endpoint+"/%s/loadbalancing/loadbalancer", regions, true)
+	if err != nil {
+		display.OutputError(&flags.OutputFormatConfig, "failed to fetch loadbalancers: %s", err)
+		return
+	}
+
+	// Flatten loadbalancers in a single array
+	var allLoadbalancers []map[string]any
+	for _, regionLoadbalancers := range containers {
+		allLoadbalancers = append(allLoadbalancers, regionLoadbalancers...)
+	}
+
+	// Filter results
+	allLoadbalancers, err = filtersLib.FilterLines(allLoadbalancers, flags.GenericFilters)
+	if err != nil {
+		display.OutputError(&flags.OutputFormatConfig, "failed to filter results: %s", err)
+		return
+	}
+
+	display.RenderTable(allLoadbalancers, cloudprojectLoadbalancerColumnsToDisplay, &flags.OutputFormatConfig)
 }
 
 func GetCloudLoadbalancer(_ *cobra.Command, args []string) {
@@ -46,7 +97,13 @@ func GetCloudLoadbalancer(_ *cobra.Command, args []string) {
 		return
 	}
 
-	common.ManageObjectRequest(fmt.Sprintf("/cloud/project/%s/loadbalancer", projectID), args[0], cloudLoadbalancerTemplate)
+	_, lb, err := locateLoadbalancer(projectID, args[0])
+	if err != nil {
+		display.OutputError(&flags.OutputFormatConfig, "%s", err)
+		return
+	}
+
+	display.OutputObject(lb, args[0], cloudLoadbalancerTemplate, &flags.OutputFormatConfig)
 }
 
 func EditCloudLoadbalancer(cmd *cobra.Command, args []string) {
@@ -56,11 +113,17 @@ func EditCloudLoadbalancer(cmd *cobra.Command, args []string) {
 		return
 	}
 
+	region, _, err := locateLoadbalancer(projectID, args[0])
+	if err != nil {
+		display.OutputError(&flags.OutputFormatConfig, "%s", err)
+		return
+	}
+
 	if err := common.EditResource(
 		cmd,
-		"/cloud/project/{serviceName}/loadbalancer/{loadBalancerId}",
-		fmt.Sprintf("/cloud/project/%s/loadbalancer/%s", projectID, url.PathEscape(args[0])),
-		CloudLoadbalancerUpdateFields,
+		"/cloud/project/{serviceName}/region/{regionName}/loadbalancing/loadbalancer/{loadBalancerId}",
+		fmt.Sprintf("/cloud/project/%s/region/%s/loadbalancing/loadbalancer/%s", projectID, url.PathEscape(region), url.PathEscape(args[0])),
+		CloudLoadbalancerUpdateSpec,
 		assets.CloudOpenapiSchema,
 	); err != nil {
 		display.OutputError(&flags.OutputFormatConfig, "%s", err)
diff --git a/internal/services/cloud/cloud_reference.go b/internal/services/cloud/cloud_reference.go
@@ -230,3 +230,14 @@ func ListDatabaseEngines(_ *cobra.Command, _ []string) {
 
 	display.RenderTable(engines, []string{"name", "description", "category", "versions", "defaultVersion"}, &flags.OutputFormatConfig)
 }
+
+func ListLoadbalancerFlavors(cmd *cobra.Command, args []string) {
+	projectID, err := getConfiguredCloudProject()
+	if err != nil {
+		display.OutputError(&flags.OutputFormatConfig, "%s", err)
+		return
+	}
+
+	endpoint := fmt.Sprintf("/cloud/project/%s/region/%s/loadbalancing/flavor", projectID, url.PathEscape(args[0]))
+	common.ManageListRequestNoExpand(endpoint, []string{"id", "name", "region"}, flags.GenericFilters)
+}
diff --git a/internal/services/cloud/templates/cloud_loadbalancer.tmpl b/internal/services/cloud/templates/cloud_loadbalancer.tmpl

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@ package cmd_test`
`6`	`6`
`7`	`7`	`import (`
`8`	`8`	`"os"`
	`9`	`+ "regexp"`
`9`	`10`	`"testing"`
`10`	`11`
`11`	`12`	`"github.com/jarcoal/httpmock"`
`@@ -75,3 +76,7 @@ func resetSubCommandFlagValues(root *cobra.Command) {`
`75`	`76`	`resetSubCommandFlagValues(c)`
`76`	`77`	`}`
`77`	`78`	`}`
	`79`	`+`
	`80`	`+func cleanWhitespacesHelper(s string) string {`
	`81`	+ return regexp.MustCompile(` +\n`).ReplaceAllString(s, "\n")
	`82`	`+}`