Skip to content

Commit 0ff6f2e

Browse files
committed
fix: final review
1 parent 32217da commit 0ff6f2e

File tree

7 files changed

+16
-10
lines changed

7 files changed

+16
-10
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,3 +46,5 @@ ai/ai-endpoints/java-langchain4j-chatbot/target/test-classes/com/ovhcloud/exampl
4646

4747
# Dot env files
4848
.env
49+
use-cases/kubeflow/ovhrc.sh
50+
use-cases/kubeflow/kubeconfig

use-cases/kubeflow/modules/kubeflow/provider.tf

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ terraform {
22
required_providers {
33
ovh = {
44
source = "ovh/ovh"
5-
version = "1.0.0"
5+
version = "1.1.0"
66
}
77

88
helm = {
@@ -20,11 +20,6 @@ terraform {
2020
version = "1.14.0"
2121
}
2222

23-
aws = {
24-
source = "hashicorp/aws"
25-
version = "5.74.0"
26-
}
27-
2823
random = {
2924
source = "hashicorp/random"
3025
version = "3.6.3"

use-cases/kubeflow/modules/kubeflow/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ variable ovh_os_region_name {
55

66
variable ovh_os_private_network_vlan_id {
77
type = string
8-
default = "10"
8+
default = "11"
99
}
1010

1111
variable ovh_gateway_size {

use-cases/kubeflow/modules/s3_user/provider.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ terraform {
22
required_providers {
33
ovh = {
44
source = "ovh/ovh"
5-
version = "1.0.0"
5+
version = "1.1.0"
66
}
77
}
88
}

use-cases/kubeflow/output.tf

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
output "access_key_id" {
2+
value = module.s3_user.access_key_id
3+
}
4+
5+
output "secret_access_key" {
6+
value = module.s3_user.secret_access_key
7+
sensitive = true
8+
}
9+
110
output "kubeflow_url" {
211
description = "Kubeflow URL"
312
value = "https://kubeflow.${var.ovh_dns_domain}"

use-cases/kubeflow/provider.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ terraform {
22
required_providers {
33
aws = {
44
source = "hashicorp/aws"
5-
version = "5.74.0"
5+
version = "5.77.0"
66
}
77
}
88
}

use-cases/kubeflow/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ variable ovh_os_region_name {
55

66
variable ovh_os_private_network_vlan_id {
77
type = string
8-
default = "10"
8+
default = "11"
99
}
1010

1111
variable ovh_gateway_size {

0 commit comments

Comments
 (0)