Merge pull request #421 from ovh/remove-warning

remove unnecessary warning in database resources

Author: scraly

ovh/resource_cloud_project_database.go

@@ -314,10 +314,8 @@ func resourceCloudProjectDatabaseRead(ctx context.Context, d *schema.ResourceDat
 	}
 
 	diags := make(diag.Diagnostics, 0)
-	warnAttr := []string{"disk_size", "advanced_configuration"}
 	for k, v := range res.ToMap() {
 		if k != "id" {
-			warningFactory(warnAttr, d, k, v, &diags)
 			d.Set(k, v)
 		} else {
 			d.SetId(fmt.Sprint(v))

ovh/resource_cloud_project_database_integration.go

@@ -171,10 +171,8 @@ func resourceCloudProjectDatabaseIntegrationRead(ctx context.Context, d *schema.
 	}
 
 	diags := make(diag.Diagnostics, 0)
-	warnAttr := []string{"type"}
 	for k, v := range res.ToMap() {
 		if k != "id" {
-			warningFactory(warnAttr, d, k, v, &diags)
 			d.Set(k, v)
 		} else {
 			d.SetId(fmt.Sprint(v))

ovh/resource_cloud_project_database_kafka_topic.go

@@ -160,10 +160,8 @@ func resourceCloudProjectDatabaseKafkaTopicRead(ctx context.Context, d *schema.R
 	}
 
 	diags := make(diag.Diagnostics, 0)
-	warnAttr := []string{"min_insync_replicas", "partitions", "replication", "retention_bytes", "retention_hours"}
 	for k, v := range res.ToMap() {
 		if k != "id" {
-			warningFactory(warnAttr, d, k, v, &diags)
 			d.Set(k, v)
 		} else {
 			d.SetId(fmt.Sprint(v))

ovh/resource_cloud_project_database_m3db_namespace.go

@@ -185,10 +185,8 @@ func resourceCloudProjectDatabaseM3dbNamespaceRead(ctx context.Context, d *schem
 	}
 
 	diags := make(diag.Diagnostics, 0)
-	warnAttr := []string{"retention_block_size_duration"}
 	for k, v := range res.ToMap() {
 		if k != "id" {
-			warningFactory(warnAttr, d, k, v, &diags)
 			d.Set(k, v)
 		} else {
 			d.SetId(fmt.Sprint(v))

ovh/resource_cloud_project_database_redis_user.go

@@ -133,10 +133,8 @@ func resourceCloudProjectDatabaseRedisUserRead(ctx context.Context, d *schema.Re
 	}
 
 	diags := make(diag.Diagnostics, 0)
-	warnAttr := []string{"channels"}
 	for k, v := range res.ToMap() {
 		if k != "id" {
-			warningFactory(warnAttr, d, k, v, &diags)
 			d.Set(k, v)
 		} else {
 			d.SetId(fmt.Sprint(v))

ovh/types_cloud_project_database.go

@@ -9,7 +9,6 @@ import (
 	"strings"
 	"time"
 
-	"github.com/hashicorp/go-cty/cty"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
@@ -1682,21 +1681,6 @@ func (opts *CloudProjectDatabaseKafkaTopicCreateOpts) FromResource(d *schema.Res
 	return opts
 }
 
-func warningFactory(warningsAttr []string, d *schema.ResourceData, k string, v interface{}, diags *diag.Diagnostics) {
-	if slices.Contains(warningsAttr, k) {
-		if _, ok := d.GetOk(k); !ok {
-			*diags = append(*diags, diag.Diagnostic{
-				Severity: diag.Warning,
-				Summary:  fmt.Sprintf("Attribute `%s` is not specified", k),
-				Detail:   fmt.Sprintf("Attribute `%s` is set to it default value : %v", k, v),
-				AttributePath: cty.Path{
-					cty.GetAttrStep{Name: k},
-				},
-			})
-		}
-	}
-}
-
 func validateIsSupEqual(v, min int) (errors []error) {
 	if v < min {
 		errors = append(errors, fmt.Errorf("Value %d is inferior of min value %d", v, min))