Skip to content

Commit 6f783be

Browse files
JayBeeDeJayBeeDe
committed
fix(dedicated_server{,_reinstall_task}): mark properties as deprecated
ref: #PUBM-43183 Signed-off-by: Jean-Baptiste Delon <[email protected]>
1 parent aa21925 commit 6f783be

File tree

9 files changed

+8
-17
lines changed

9 files changed

+8
-17
lines changed

‎docs/guides/dedicated_server_migration.md‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ terraform apply
3737

3838
## Second step: backport your previous task details into the imported resource
3939

40-
This step is manual and requires you to convert the previous installation details from resource `ovh_dedicated_server_install_task` to the new fields of resource `ovh_dedicated_server`: `os`, `customizations`, `properties` and `storage`.
40+
This step is manual and requires you to convert the previous installation details from resource `ovh_dedicated_server_install_task` to the new fields of resource `ovh_dedicated_server`: `os`, `customizations` and `storage`.
4141

4242
Let's take an example: if you previously used the following configuration:
4343

@@ -74,7 +74,6 @@ resource "ovh_dedicated_server" "srv" {
7474
ssh_key = "ssh-ed25519 AAAAC3..."
7575
}
7676
os = "debian12_64"
77-
properties = null
7877
storage = null
7978
}
8079
```

‎docs/resources/dedicated_server.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ resource "ovh_dedicated_server" "server" {
139139
* `raid_level` - Software raid type
140140
* `size` - Partition size in MiB
141141
* `scheme_name` - Partitioning scheme (if applicable with selected operating system)
142-
* `properties` - Arbitrary properties to pass to cloud-init's config drive datasource
142+
* `properties` - Deprecated, has no effect
143143

144144
### Arguments used to control the lifecycle of a dedicated server
145145

‎docs/resources/dedicated_server_reinstall_task.md‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,6 @@ resource "ovh_dedicated_server_reinstall_task" "server_install" {
128128
image_check_sum_type = "sha512"
129129
image_url = "https://github.com/ashmonger/akution_test/releases/download/0.5-compress/deb11k6.qcow2"
130130
}
131-
properties = {
132-
essential = "false"
133-
role = "webservers"
134-
}
135131
}
136132
```
137133

@@ -241,7 +237,7 @@ The following arguments are supported:
241237

242238
~> **WARNING** Some customizations may be required on some Operating Systems. [Check how to list the available and required customization(s) for your operating system](https://help.ovhcloud.com/csm/en-dedicated-servers-api-os-installation?id=kb_article_view&sysparm_article=KB0061951#os-inputs) (do not forget to adapt camel case customization name to snake case parameter).
243239

244-
* `properties` - Arbitrary properties to pass to cloud-init's config drive datasource. It supports any key with any string value.
240+
* `properties` - Deprecated, has no effect
245241

246242
* `storage`: OS reinstallation storage configurations. [More details about disks, hardware/software RAID and partitioning configuration](https://help.ovhcloud.com/csm/en-dedicated-servers-api-partitioning?id=kb_article_view&sysparm_article=KB0043882) (do not forget to adapt camel case parameters to snake case parameters).
247243
* `disk_group_id`: Disk group id to install the OS to (default is 0, meaning automatic).

‎examples/resources/dedicated_server_reinstall_task/example_4.tf‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,4 @@ resource "ovh_dedicated_server_reinstall_task" "server_install" {
1919
image_check_sum_type = "sha512"
2020
image_url = "https://github.com/ashmonger/akution_test/releases/download/0.5-compress/deb11k6.qcow2"
2121
}
22-
properties = {
23-
essential = "false"
24-
role = "webservers"
25-
}
2622
}

‎ovh/resource_dedicated_server_gen.go‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎ovh/resource_dedicated_server_reinstall_task.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ func resourceDedicatedServerReinstallTask() *schema.Resource {
130130
Type: schema.TypeMap,
131131
Optional: true,
132132
ForceNew: true,
133-
Description: "Arbitrary properties to pass to cloud-init's config drive datasource",
133+
Description: "Attribute 'properties' is deprecated and has no effect",
134134
Elem: &schema.Schema{
135135
Type: schema.TypeString,
136136
},

‎templates/guides/dedicated_server_migration.md‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ terraform apply
3737

3838
## Second step: backport your previous task details into the imported resource
3939

40-
This step is manual and requires you to convert the previous installation details from resource `ovh_dedicated_server_install_task` to the new fields of resource `ovh_dedicated_server`: `os`, `customizations`, `properties` and `storage`.
40+
This step is manual and requires you to convert the previous installation details from resource `ovh_dedicated_server_install_task` to the new fields of resource `ovh_dedicated_server`: `os`, `customizations` and `storage`.
4141

4242
Let's take an example: if you previously used the following configuration:
4343

@@ -74,7 +74,6 @@ resource "ovh_dedicated_server" "srv" {
7474
ssh_key = "ssh-ed25519 AAAAC3..."
7575
}
7676
os = "debian12_64"
77-
properties = null
7877
storage = null
7978
}
8079
```

‎templates/resources/dedicated_server.md.tmpl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ Use this resource to order and manage a dedicated server.
8686
* `raid_level` - Software raid type
8787
* `size` - Partition size in MiB
8888
* `scheme_name` - Partitioning scheme (if applicable with selected operating system)
89-
* `properties` - Arbitrary properties to pass to cloud-init's config drive datasource
89+
* `properties` - Attribute 'properties' is deprecated and has no effect
9090

9191
### Arguments used to control the lifecycle of a dedicated server
9292

‎templates/resources/dedicated_server_reinstall_task.md.tmpl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ The following arguments are supported:
8585

8686
~> **WARNING** Some customizations may be required on some Operating Systems. [Check how to list the available and required customization(s) for your operating system](https://help.ovhcloud.com/csm/en-dedicated-servers-api-os-installation?id=kb_article_view&sysparm_article=KB0061951#os-inputs) (do not forget to adapt camel case customization name to snake case parameter).
8787

88-
* `properties` - Arbitrary properties to pass to cloud-init's config drive datasource. It supports any key with any string value.
88+
* `properties` - Attribute 'properties' is deprecated and has no effect.
8989

9090
* `storage`: OS reinstallation storage configurations. [More details about disks, hardware/software RAID and partitioning configuration](https://help.ovhcloud.com/csm/en-dedicated-servers-api-partitioning?id=kb_article_view&sysparm_article=KB0043882) (do not forget to adapt camel case parameters to snake case parameters).
9191
* `disk_group_id`: Disk group id to install the OS to (default is 0, meaning automatic).

0 commit comments

Comments
 (0)