Avoid this unnecessary copy by using a "const" reference.

eduar-hte · eduar-hte · commit 60dad6a3d5d4 · 2024-10-19T13:13:38.000-03:00
- Reported by Sonarcloud
diff --git a/test/optimization/optimization.cc b/test/optimization/optimization.cc
@@ -97,7 +97,7 @@ int main(int argc, char **argv) {
             }
 
             if (const auto *rwo = dynamic_cast<modsecurity::RuleWithOperator *>(z.get())) {
-                const auto op = rwo->getOperatorName();
+                const auto &op = rwo->getOperatorName();
                 if (operators.count(op) > 0) {
                     operators[op] = 1 + operators[op];
                 } else {

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ int main(int argc, char **argv) {`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`if (const auto rwo = dynamic_cast<modsecurity::RuleWithOperator >(z.get())) {`
`100`		`- const auto op = rwo->getOperatorName();`
	`100`	`+ const auto &op = rwo->getOperatorName();`
`101`	`101`	`if (operators.count(op) > 0) {`
`102`	`102`	`operators[op] = 1 + operators[op];`
`103`	`103`	`} else {`