Skip to content

Commit 619758c

Browse files
author
Felipe "Zimmerle" Costa
committed
iis: Adds condition to avoid the use of 32b msi on a 64b os
The 64bits version of the package offer the possibility to install the 32bits version of the DLL along with all 32bits dependencies.
1 parent 93a86f6 commit 619758c

File tree

1 file changed

+11
-26
lines changed

1 file changed

+11
-26
lines changed

iis/installer.wxs

Lines changed: 11 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -83,18 +83,12 @@
8383
<Condition Message="This setup requires IIS 6.0, 7.0 or 8.0 is installed."><![CDATA[(IIS="#7") OR (IIS="#6") OR (IIS="#8")]]></Condition>
8484
<!-- Version 2.7.6 had an uninstall issue that leaves some files behind. Asking the user to manually hash this out. -->
8585
<Condition Message="A older version of ModSecurityIIS was found in your computer. Please complete uninstall by removing the following file: [FILEEXISTS]. You may have to remove ModSecurity module from IIS, use the IIS Manager to do so."><![CDATA[(NOT FILEEXISTS) OR (Installed)]]></Condition>
86-
<!--
87-
Won't necessary. We can install 32bits stuff in a 64 machine. If IIS is proper
88-
configured it will work like a charm.
89-
90-
<Condition Message="64-bit operating system was detected, please use the 64-bit installer.">
91-
<?if $(var.Win64) = "yes" ?>
92-
VersionNT64
93-
<?else?>
94-
NOT VersionNT64
95-
<?endif?>
96-
</Condition>
97-
-->
86+
<Condition Message="64-bit operating system was detected, please use the 64-bit installer.">
87+
<?if $(var.Win64) = "yes" ?>
88+
VersionNT64
89+
<?else ?>
90+
NOT VersionNT64
91+
<?endif ?></Condition>
9892
<Media Id="1" Cabinet="simple.cab" EmbedCab="yes" />
9993
<Directory Id="TARGETDIR" Name="SourceDir">
10094
<?if $(var.Win64) = "yes" ?>
@@ -408,12 +402,8 @@
408402
<UI Id="WixUI_FeatureTreeCustom">
409403
<Dialog Id="CustomizeDlgModSec" Width="370" Height="270" Title="!(loc.CustomizeDlg_Title)" TrackDiskSpace="yes">
410404
<Control Id="Tree" Type="SelectionTree" X="25" Y="85" Width="175" Height="115" Property="_BrowseProperty" Sunken="yes" TabSkip="no" Text="!(loc.CustomizeDlgTree)">
411-
<Publish Property="DisableButton" Value="1">
412-
(NOT &amp;ModSec64=3) AND (NOT &amp;ModSec32=3)
413-
</Publish>
414-
<Publish Property="DisableButton" Value="0">
415-
&amp;ModSec64=3 OR &amp;ModSec32=3
416-
</Publish>
405+
<Publish Property="DisableButton" Value="1">(NOT &amp;ModSec64=3) AND (NOT &amp;ModSec32=3)</Publish>
406+
<Publish Property="DisableButton" Value="0">&amp;ModSec64=3 OR &amp;ModSec32=3</Publish>
417407
</Control>
418408
<Control Id="Browse" Type="PushButton" X="294" Y="210" Width="66" Height="17" Text="!(loc.CustomizeDlgBrowse)">
419409
<Publish Event="SelectionBrowse" Value="BrowseDlg">1</Publish>
@@ -431,12 +421,8 @@
431421
<Control Id="Back" Type="PushButton" X="192" Y="243" Width="56" Height="17" Text="!(loc.WixUIBack)" />
432422
<Control Id="Next" Type="PushButton" X="248" Y="243" Width="56" Height="17" Default="yes" Text="!(loc.WixUINext)">
433423
<Subscribe Event="SelectionNoItems" Attribute="Enabled" />
434-
<Condition Action="disable">
435-
DisableButton = 1
436-
</Condition>
437-
<Condition Action="enable">
438-
DisableButton = 0
439-
</Condition>
424+
<Condition Action="disable">DisableButton = 1</Condition>
425+
<Condition Action="enable">DisableButton = 0</Condition>
440426
</Control>
441427
<Control Id="Cancel" Type="PushButton" X="304" Y="243" Width="56" Height="17" Cancel="yes" Text="!(loc.WixUICancel)">
442428
<Publish Event="SpawnDialog" Value="CancelDlg">1</Publish>
@@ -564,8 +550,7 @@
564550
<CustomAction Id="InstallConf" Execute="deferred" Impersonate="no" Return="check" Directory="INSTALLFOLDER" ExeCommand="&quot;[SystemFolder]inetsrv\appcmd.exe&quot; set config /section:&quot;system.webServer/ModSecurity&quot; /&quot;enabled:true&quot; /&quot;configFile:[INSTALLFOLDER]modsecurity_iis.conf&quot;" />
565551
<CustomAction Id="UninstallConf" Execute="deferred" Impersonate="no" Return="check" Directory="INSTALLFOLDER" ExeCommand="&quot;[SystemFolder]inetsrv\appcmd.exe&quot; clear config -section:&quot;system.webServer/ModSecurity&quot;" />
566552
<?endif ?>
567-
568-
<DirectoryRef Id="TARGETDIR">
553+
<DirectoryRef Id="TARGETDIR">
569554
<?if $(var.Win64) = "yes" ?>
570555
<Merge Id="VCRedist64" SourceFile="wix\Microsoft_VC120_CRT_x64.msm" DiskId="1" Language="0" />
571556
<Merge Id="VCRedist32" SourceFile="wix\Microsoft_VC120_CRT_x86.msm" DiskId="1" Language="0" />

0 commit comments

Comments
 (0)