RocksDB: Pull some RocksDB config options out into configuration.json

Change-Id: I9a60f44eebab31967bb0e02e591322aaf12fbf24
Reviewed-on: http://review.couchbase.org/82748
Reviewed-by: Dave Rigby <[email protected]>
Tested-by: Build Bot <[email protected]>

Author: jameseh96

engines/ep/configuration.json

@@ -807,6 +807,39 @@
             "descr": "Perform a file sync() operation after every N bytes written. Disabled if set to 0.",
             "type" : "size_t"
         },
+        "rocksdb_write_buffer_size": {
+            "default": "64",
+            "descr": "The maximum size in MB of a single memtable in rocksdb.",
+            "type": "size_t",
+            "validator": {
+                "range": {
+                    "max": 100000,
+                    "min": 0
+                }
+            }
+        },
+        "rocksdb_db_write_buffer_size": {
+            "default": "0",
+            "descr": "The maximum total size in MB of all memtables in rocksdb, per shard.",
+            "type": "size_t",
+            "validator": {
+                "range": {
+                    "max": 100000,
+                    "min": 0
+                }
+            }
+        },
+        "rocksdb_max_write_buffer_number": {
+            "default": "0",
+            "descr": "The maximum number of memtables in rocksdb before stalling writes, per shard.",
+            "type": "size_t",
+            "validator": {
+                "range": {
+                    "max": 100000,
+                    "min": 0
+                }
+            }
+        },
         "time_synchronization": {
             "default": "disabled",
             "descr": "No longer supported. This config parameter has no effect.",

engines/ep/src/kvstore_config.cc

@@ -39,7 +39,10 @@ KVStoreConfig::KVStoreConfig(Configuration& config, uint16_t shardid)
                     config.getDbname(),
                     config.getBackend(),
                     shardid,
-                    config.isCollectionsPrototypeEnabled()) {
+                    config.isCollectionsPrototypeEnabled(),
+                    config.getRocksdbWriteBufferSize(),
+                    config.getRocksdbDbWriteBufferSize(),
+                    config.getRocksdbMaxWriteBufferNumber()) {
     setPeriodicSyncBytes(config.getFsyncAfterEveryNBytesWritten());
     config.addValueChangedListener("fsync_after_every_n_bytes_written",
                                    new ConfigChangeListener(*this));
@@ -50,15 +53,21 @@ KVStoreConfig::KVStoreConfig(uint16_t _maxVBuckets,
                              const std::string& _dbname,
                              const std::string& _backend,
                              uint16_t _shardId,
-                             bool _persistDocNamespace)
+                             bool _persistDocNamespace,
+                             size_t writeBufferSize,
+                             size_t dbWriteBufferSize,
+                             size_t maxWriteBufferNumber)
     : maxVBuckets(_maxVBuckets),
       maxShards(_maxShards),
       dbname(_dbname),
       backend(_backend),
       shardId(_shardId),
       logger(&global_logger),
       buffered(true),
-      persistDocNamespace(_persistDocNamespace) {
+      persistDocNamespace(_persistDocNamespace),
+      writeBufferSize(writeBufferSize),
+      dbWriteBufferSize(dbWriteBufferSize),
+      maxWriteBufferNumber(maxWriteBufferNumber) {
 }
 
 KVStoreConfig& KVStoreConfig::setLogger(Logger& _logger) {

engines/ep/src/kvstore_config.h

@@ -44,7 +44,10 @@ class KVStoreConfig {
                   const std::string& _dbname,
                   const std::string& _backend,
                   uint16_t _shardId,
-                  bool persistDocNamespace);
+                  bool persistDocNamespace,
+                  size_t writeBufferSize = 0,
+                  size_t dbWriteBufferSize = 0,
+                  size_t maxWriteBufferNumber = 0);
 
     uint16_t getMaxVBuckets() const {
         return maxVBuckets;
@@ -108,6 +111,28 @@ class KVStoreConfig {
         periodicSyncBytes = bytes;
     }
 
+    /**
+     * RocksDB: The maximum size in MB of a single memtable.
+     */
+    size_t getWriteBufferSize() {
+        return writeBufferSize;
+    }
+
+    /**
+     * RocksDB: The maximum total size in MB of all memtables, per shard.
+     */
+    size_t getDbWriteBufferSize() {
+        return dbWriteBufferSize;
+    }
+
+    /**
+     * RocksDB: The maximum number of memtables before stalling writes, per
+     * shard.
+     */
+    size_t getMaxWriteBufferNumber() {
+        return maxWriteBufferNumber;
+    }
+
 private:
     class ConfigChangeListener;
 
@@ -125,4 +150,8 @@ class KVStoreConfig {
      * N bytes written.
      */
     uint64_t periodicSyncBytes;
+
+    size_t writeBufferSize;
+    size_t dbWriteBufferSize;
+    size_t maxWriteBufferNumber;
 };

engines/ep/src/rocksdb-kvstore/rocksdb-kvstore.cc

@@ -53,6 +53,12 @@ RocksDBKVStore::~RocksDBKVStore() {
 void RocksDBKVStore::open() {
     rdbOptions.create_if_missing = true;
     rdbOptions.create_missing_column_families = true;
+    rdbOptions.write_buffer_size =
+            1024 * 1024 * configuration.getWriteBufferSize();
+    rdbOptions.db_write_buffer_size =
+            1024 * 1024 * configuration.getDbWriteBufferSize();
+    rdbOptions.max_write_buffer_number =
+            configuration.getMaxWriteBufferNumber();
 
     seqnoCFOptions.comparator = &vbidSeqnoComparator;
 

engines/ep/tests/ep_testsuite.cc

@@ -6421,6 +6421,9 @@ static enum test_result test_mb19687_fixed(ENGINE_HANDLE* h,
                 "ep_replication_throttle_cap_pcnt",
                 "ep_replication_throttle_queue_cap",
                 "ep_replication_throttle_threshold",
+                "ep_rocksdb_db_write_buffer_size",
+                "ep_rocksdb_max_write_buffer_number",
+                "ep_rocksdb_write_buffer_size",
                 "ep_time_synchronization",
                 "ep_uuid",
                 "ep_vb0",
@@ -6664,6 +6667,9 @@ static enum test_result test_mb19687_fixed(ENGINE_HANDLE* h,
                 "ep_replication_throttle_cap_pcnt",
                 "ep_replication_throttle_queue_cap",
                 "ep_replication_throttle_threshold",
+                "ep_rocksdb_db_write_buffer_size",
+                "ep_rocksdb_max_write_buffer_number",
+                "ep_rocksdb_write_buffer_size",
                 "ep_rollback_count",
                 "ep_startup_time",
                 "ep_storage_age",