Set default visibility of opentelemetry_proto to hidden

Author: owent

cmake/opentelemetry-proto.cmake

@@ -321,8 +321,13 @@ target_include_directories(
                              "$<INSTALL_INTERFACE:include>")
 
 # Disable include-what-you-use and clang-tidy on generated code.
-set_target_properties(opentelemetry_proto PROPERTIES CXX_INCLUDE_WHAT_YOU_USE ""
-                                                     CXX_CLANG_TIDY "")
+set_target_properties(
+  opentelemetry_proto
+  PROPERTIES CXX_INCLUDE_WHAT_YOU_USE ""
+             CXX_CLANG_TIDY ""
+             C_VISIBILITY_PRESET "hidden"
+             CXX_VISIBILITY_PRESET "hidden"
+             VISIBILITY_INLINES_HIDDEN OFF)
 if(NOT Protobuf_INCLUDE_DIRS AND TARGET protobuf::libprotobuf)
   get_target_property(Protobuf_INCLUDE_DIRS protobuf::libprotobuf
                       INTERFACE_INCLUDE_DIRECTORIES)
@@ -342,6 +347,9 @@ if(WITH_OTLP_GRPC)
 
   if(OTELCPP_PROTO_LIB_TYPE STREQUAL "SHARED_LIBRARY")
     if(CMAKE_SYSTEM_NAME MATCHES "Windows|MinGW|WindowsStore")
+      # The codes generated by gRPC plugin do not support dll export/import
+      # declarations. To work around this, we enable WINDOWS_EXPORT_ALL_SYMBOLS
+      # property to export all symbols when building a shared library.
       set_target_properties(opentelemetry_proto_grpc
                             PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS ON)
     endif()
@@ -353,7 +361,8 @@ if(WITH_OTLP_GRPC)
     PROPERTIES CXX_INCLUDE_WHAT_YOU_USE ""
                CXX_CLANG_TIDY ""
                C_VISIBILITY_PRESET "default"
-               CXX_VISIBILITY_PRESET "default")
+               CXX_VISIBILITY_PRESET "default"
+               VISIBILITY_INLINES_HIDDEN OFF)
 
   list(APPEND OPENTELEMETRY_PROTO_TARGETS opentelemetry_proto_grpc)
   target_link_libraries(opentelemetry_proto_grpc PUBLIC opentelemetry_proto)
@@ -365,7 +374,8 @@ if(WITH_OTLP_GRPC)
   # opentelemetry_exporter_otlp_grpc_client as a static library.
   get_target_property(grpc_lib_type gRPC::grpc++ TYPE)
 
-  if(grpc_lib_type STREQUAL "SHARED_LIBRARY")
+  if(grpc_lib_type STREQUAL "SHARED_LIBRARY" OR OTELCPP_PROTO_LIB_TYPE STREQUAL
+                                                "SHARED_LIBRARY")
     target_link_libraries(opentelemetry_proto_grpc PUBLIC gRPC::grpc++)
   endif()
   set_target_properties(opentelemetry_proto_grpc PROPERTIES EXPORT_NAME

cmake/tools.cmake

@@ -280,7 +280,7 @@ function(project_build_tools_set_import_declaration OUTPUT_VARNAME)
           ""
           PARENT_SCOPE)
     endif()
-  elseif(SunPro)
+  elseif(CMAKE_CXX_COMPILER_ID STREQUAL "SunPro")
     set(${OUTPUT_VARNAME}
         "__global"
         PARENT_SCOPE)