Skip to content

Commit 1474507

Browse files
owineclaude
andcommitted
fix: properly quote CRITICAL_SERVICES in SSH env command
Fixes zsh glob expansion error when passing CRITICAL_SERVICES='[]' to remote shell via SSH env command. Error: 'zsh:1: no matches found: CRITICAL_SERVICES=[]' Changed from single quotes to double quotes around $CRITICAL_SERVICES to ensure proper quoting on the remote shell, preventing zsh from attempting glob expansion on the square brackets. Resolves docker-piwine-office run #20544294753 health check failure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent b208790 commit 1474507

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/deployment/health-check.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ log_info "Health check timeout: ${HEALTH_TIMEOUT}s, Command timeout: ${COMMAND_T
7878
export OP_SERVICE_ACCOUNT_TOKEN="$OP_TOKEN"
7979

8080
set +e
81-
HEALTH_RESULT=$(ssh_retry 3 5 "ssh -o \"StrictHostKeyChecking no\" $SSH_USER@$SSH_HOST env OP_SERVICE_ACCOUNT_TOKEN=\"$OP_TOKEN\" HEALTH_TIMEOUT=\"$HEALTH_TIMEOUT\" COMMAND_TIMEOUT=\"$COMMAND_TIMEOUT\" CRITICAL_SERVICES='$CRITICAL_SERVICES' /bin/bash -s $STACKS \"$HAS_DOCKGE\"" << 'EOF'
81+
HEALTH_RESULT=$(ssh_retry 3 5 "ssh -o \"StrictHostKeyChecking no\" $SSH_USER@$SSH_HOST env OP_SERVICE_ACCOUNT_TOKEN=\"$OP_TOKEN\" HEALTH_TIMEOUT=\"$HEALTH_TIMEOUT\" COMMAND_TIMEOUT=\"$COMMAND_TIMEOUT\" CRITICAL_SERVICES=\"$CRITICAL_SERVICES\" /bin/bash -s $STACKS \"$HAS_DOCKGE\"" << 'EOF'
8282
set -e
8383
8484
# Get arguments passed to script (excluding sensitive OP_TOKEN)

0 commit comments

Comments
 (0)