Skip to content

Commit 3f88936

Browse files
owineclaude
andcommitted
fix: add continue-on-error to health check step for proper rollback
The health check step was missing continue-on-error: true, which means if it failed, the workflow would stop immediately and rollback steps would not execute. With this fix: - Health check failures are properly captured in step.outcome - Rollback steps can execute when health check fails - Report Deployment Status can properly detect and report failures - Overall workflow failure reporting works correctly This ensures the error handling chain works as designed: deploy (continue-on-error) -> health (continue-on-error) -> rollback (if needed) -> report status (exit 1 on failure) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 70151a2 commit 3f88936

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.github/workflows/deploy.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -518,6 +518,7 @@ jobs:
518518
- name: Health Check All Services
519519
id: health
520520
if: steps.backup.outputs.deployment_needed == 'true' && steps.deploy.outcome == 'success'
521+
continue-on-error: true
521522
run: |
522523
./.compose-workflow/scripts/deployment/health-check.sh \
523524
--stacks "${{ join(fromJSON(inputs.stacks), ' ') }}" \

0 commit comments

Comments
 (0)