apply requested changes

Author: theScrabi

owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/OwnCloudClientFactory.java

@@ -61,15 +61,14 @@ public class HttpClient {
     private OkHttpClient mOkHttpClient = null;
 
     protected HttpClient(Context context) {
+        if(context == null) {
+            Timber.e("Context may not be NULL!");
+            throw new NullPointerException("Context may not be NULL!");
+        }
         mContext = context;
     }
 
     public OkHttpClient getOkHttpClient() {
-        if (mContext == null) {
-            Timber.e("Context not initialized call HttpClient.setContext(applicationContext) in the MainApp.onCrate()");
-            throw new RuntimeException("Context not initialized call HttpClient.setContext(applicationContext) in the" +
-                    " MainApp.onCrate()");
-        }
         if (mOkHttpClient == null) {
             try {
                 final X509TrustManager trustManager = new AdvancedX509TrustManager(

owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/http/HttpClient.java

@@ -60,8 +60,8 @@ abstract class HttpBaseMethod constructor(url: URL) {
     @Throws(Exception::class)
     open fun execute(httpClient: HttpClient): Int {
         val okHttpClient = httpClient.okHttpClient.newBuilder().apply {
-            retryOnConnectionFailure?.let { retryOnConnectionFailure(it) }
-            followRedirects?.let { followRedirects(it) }
+            retryOnConnectionFailure.let { retryOnConnectionFailure(it) }
+            followRedirects.let { followRedirects(it) }
             readTimeoutUnit?.let { unit ->
                 readTimeoutVal?.let { readTimeout(it, unit) }
             }
@@ -152,12 +152,7 @@ abstract class HttpBaseMethod constructor(url: URL) {
     //         Setter
     //////////////////////////////
     // Connection parameters
-    /*
-    open fun setRetryOnConnectionFailure(retryOnConnectionFailure: Boolean) {
-        retryOnConnectionFailureVal = true
-    }
 
-     */
 
     open fun setReadTimeout(readTimeout: Long, timeUnit: TimeUnit) {
         readTimeoutVal = readTimeout

owncloudComLibrary/src/main/java/com/owncloud/android/lib/common/http/methods/HttpBaseMethod.kt

@@ -74,7 +74,6 @@ public void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
         setContentView(R.layout.main);
 
-        Timber.plant(new DebugTree());
         mHandler = new Handler();
 
         final Uri serverUri = Uri.parse(getString(R.string.server_base_url));
@@ -86,8 +85,6 @@ public void onCreate(Bundle savedInstanceState) {
                 true,
                 SingleSessionManager.getDefaultSingleton());
 
-        mClient = OwnCloudClientFactory.createOwnCloudClient(serverUri, this, true);
-
         mClient.setCredentials(
                 OwnCloudCredentialsFactory.newBasicCredentials(
                         getString(R.string.username),