test: create tests for OCRemoteRolesDataSource and OCRolesRepository

Author: joragua

owncloudData/src/test/java/com/owncloud/android/data/roles/datasources/implementation/OCRemoteRolesDataSourceTest.kt

@@ -0,0 +1,66 @@
+/**
+ * ownCloud Android client application
+ *
+ * @author Jorge Aguado Recio
+ *
+ * Copyright (C) 2025 ownCloud GmbH.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package com.owncloud.android.data.roles.datasources.implementation
+
+import com.owncloud.android.data.ClientManager
+import com.owncloud.android.data.roles.datasources.implementation.OCRemoteRolesDataSource.Companion.toModel
+import com.owncloud.android.lib.resources.roles.services.OCRolesService
+import com.owncloud.android.testutil.OC_ACCOUNT_NAME
+import com.owncloud.android.testutil.SPACE_PERMISSIONS_RESPONSE
+import com.owncloud.android.utils.createRemoteOperationResultMock
+import io.mockk.every
+import io.mockk.mockk
+import io.mockk.verify
+import junit.framework.TestCase.assertEquals
+import org.junit.Before
+import org.junit.Test
+
+class OCRemoteRolesDataSourceTest {
+
+    private lateinit var ocRemoteRolesDataSource: OCRemoteRolesDataSource
+
+    private val ocRolesService: OCRolesService = mockk()
+    private val clientManager: ClientManager = mockk(relaxed = true)
+
+    @Before
+    fun setUp() {
+        ocRemoteRolesDataSource = OCRemoteRolesDataSource(clientManager)
+        every { clientManager.getRolesService(OC_ACCOUNT_NAME) } returns ocRolesService
+    }
+
+    @Test
+    fun `getRoles returns a list of OCRole with all available roles from the server`() {
+        val getRolesResult = createRemoteOperationResultMock(SPACE_PERMISSIONS_RESPONSE.roles, isSuccess = true)
+
+        every {
+            ocRolesService.getRoles()
+        } returns getRolesResult
+
+        val roles = ocRemoteRolesDataSource.getRoles(OC_ACCOUNT_NAME)
+        assertEquals(SPACE_PERMISSIONS_RESPONSE.roles.map { it.toModel() }, roles)
+
+        verify(exactly = 1) {
+            clientManager.getRolesService(OC_ACCOUNT_NAME)
+            ocRolesService.getRoles()
+        }
+    }
+
+}

owncloudData/src/test/java/com/owncloud/android/data/roles/repository/OCRolesRepositoryTest.kt

@@ -0,0 +1,51 @@
+/**
+ * ownCloud Android client application
+ *
+ * @author Jorge Aguado Recio
+ *
+ * Copyright (C) 2025 ownCloud GmbH.
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package com.owncloud.android.data.roles.repository
+
+import com.owncloud.android.data.roles.datasources.RemoteRolesDataSource
+import com.owncloud.android.testutil.OC_ACCOUNT_NAME
+import com.owncloud.android.testutil.SPACE_MEMBERS
+import io.mockk.every
+import io.mockk.mockk
+import io.mockk.verify
+import junit.framework.TestCase.assertEquals
+import org.junit.Test
+
+class OCRolesRepositoryTest {
+
+    private val remoteRolesDataSource = mockk<RemoteRolesDataSource>()
+    private val ocRolesRepository = OCRolesRepository(remoteRolesDataSource)
+
+    @Test
+    fun `getRoles returns a list of OCRole`() {
+        every {
+            remoteRolesDataSource.getRoles(OC_ACCOUNT_NAME)
+        } returns SPACE_MEMBERS.roles
+
+        val roles = ocRolesRepository.getRoles(OC_ACCOUNT_NAME)
+        assertEquals(SPACE_MEMBERS.roles, roles)
+
+        verify(exactly = 1) {
+            remoteRolesDataSource.getRoles(OC_ACCOUNT_NAME)
+        }
+    }
+
+}

owncloudTestUtil/src/main/java/com/owncloud/android/testutil/OCSpace.kt

@@ -26,6 +26,7 @@ import com.owncloud.android.data.spaces.db.SpaceRootEntity
 import com.owncloud.android.data.spaces.db.SpaceSpecialEntity
 import com.owncloud.android.data.spaces.db.SpacesEntity
 import com.owncloud.android.data.spaces.db.SpacesWithSpecials
+import com.owncloud.android.domain.roles.model.OCRole
 import com.owncloud.android.domain.spaces.model.OCSpace
 import com.owncloud.android.domain.spaces.model.OCSpace.Companion.SPACE_ID_SHARES
 import com.owncloud.android.domain.spaces.model.SpaceDeleted
@@ -34,18 +35,17 @@ import com.owncloud.android.domain.spaces.model.SpaceMember
 import com.owncloud.android.domain.spaces.model.SpaceMembers
 import com.owncloud.android.domain.spaces.model.SpaceOwner
 import com.owncloud.android.domain.spaces.model.SpaceQuota
-import com.owncloud.android.domain.spaces.model.SpaceRole
 import com.owncloud.android.domain.spaces.model.SpaceRoot
 import com.owncloud.android.domain.spaces.model.SpaceSpecial
 import com.owncloud.android.domain.spaces.model.SpaceSpecialFolder
 import com.owncloud.android.domain.spaces.model.SpaceUser
+import com.owncloud.android.lib.resources.roles.responses.RoleResponse
 import com.owncloud.android.lib.resources.spaces.responses.GrantedToV2Response
 import com.owncloud.android.lib.resources.spaces.responses.PermissionsResponse
 import com.owncloud.android.lib.resources.spaces.responses.QuotaResponse
 import com.owncloud.android.lib.resources.spaces.responses.RootResponse
 import com.owncloud.android.lib.resources.spaces.responses.SpacePermissionsResponse
 import com.owncloud.android.lib.resources.spaces.responses.SpaceResponse
-import com.owncloud.android.lib.resources.spaces.responses.SpaceRoleResponse
 import com.owncloud.android.lib.resources.spaces.responses.UserResponse
 
 const val WEB_DAV_URL = "https://server.url/dav/spaces/8871f4f3-fc6f-4a66-8bed-62f175f76f3805bca744-d89f-4e9c-a990-25a0d7f03fe9"
@@ -338,9 +338,9 @@ val SPACE_RESPONSE =
 val SPACE_PERMISSIONS_RESPONSE = SpacePermissionsResponse(
     actions = listOf("libre.graph/driveItem/permissions/delete", "libre.graph/driveItem/permissions/update"),
     roles = listOf(
-        SpaceRoleResponse(displayName = "Can view", id = "a8d5fe5e-96e3-418d-825b-534dbdf22b99"),
-        SpaceRoleResponse(displayName = "Can edit", id = "58c63c02-1d89-4572-916a-870abc5a1b7d"),
-        SpaceRoleResponse(displayName = "Can manage", id = "312c0871-5ef7-4b3a-85b6-0e4074c64049")
+        RoleResponse(displayName = "Can view", id = "a8d5fe5e-96e3-418d-825b-534dbdf22b99"),
+        RoleResponse(displayName = "Can edit", id = "58c63c02-1d89-4572-916a-870abc5a1b7d"),
+        RoleResponse(displayName = "Can manage", id = "312c0871-5ef7-4b3a-85b6-0e4074c64049")
     ),
     members = listOf(
         PermissionsResponse(
@@ -354,9 +354,9 @@ val SPACE_PERMISSIONS_RESPONSE = SpacePermissionsResponse(
 
 val SPACE_MEMBERS = SpaceMembers(
     roles = listOf(
-        SpaceRole(displayName = "Can view", id = "a8d5fe5e-96e3-418d-825b-534dbdf22b99"),
-        SpaceRole(displayName = "Can edit", id = "58c63c02-1d89-4572-916a-870abc5a1b7d"),
-        SpaceRole(displayName = "Can manage", id = "312c0871-5ef7-4b3a-85b6-0e4074c64049")
+        OCRole(displayName = "Can view", id = "a8d5fe5e-96e3-418d-825b-534dbdf22b99"),
+        OCRole(displayName = "Can edit", id = "58c63c02-1d89-4572-916a-870abc5a1b7d"),
+        OCRole(displayName = "Can manage", id = "312c0871-5ef7-4b3a-85b6-0e4074c64049")
     ),
     members = listOf(
         SpaceMember(