Skip to content

Commit 6d34130

Browse files
authored
Merge pull request #2466 from owncloud/release_2.10.0
Release 2.10.0
2 parents 026c7da + 29eec6a commit 6d34130

File tree

19 files changed

+59
-229
lines changed

19 files changed

+59
-229
lines changed

.github/release_template.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ AC:
77
- [ ] [GIT] Create branch release_Y.Y.Y in owncloud/android-library from master (almost feature-frozen)
88
- [ ] [GIT] Create branch release_X.X.X in owncloud/android from master (almost feature-frozen)
99
- [ ] [DEV] Update version number and name in AndroidManifest.xml in android module
10-
- [ ] [DEV] Update version number and name in AndroidManifest.xml in oc_jb_workaround module
1110
- [ ] [DIS] Create changelog file (< 500 chars) and add to CHANGELOG.md in owncloud/android
1211
- [ ] [QA] Design Test plan
1312
- [ ] [QA] Regression Test plan
@@ -24,7 +23,6 @@ AC:
2423
- [ ] [DIS] Update screenshots and store listing, if needed, in Blackberry World
2524
- [ ] [GIT] merge master branch into stable, in owncloud/android-library
2625
- [ ] [GIT] merge master branch into stable, in owncloud/android
27-
- [ ] [DIS] push OC JB workaround app to Play Store
2826
- [ ] [DOC] Update owncloud.org/download version numbers (notify rocketchat #marketing)
2927

3028

.gitignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ target/
1717

1818
# Local configuration files (sdk path, etc)
1919
local.properties
20-
oc_workaround/local.properties
2120
oc_framework/local.properties
2221
oc_framework-test-project/local.properties
2322
tests/local.properties
@@ -28,7 +27,6 @@ lint.xml
2827

2928
# Proguard README
3029
proguard-project.txt
31-
oc_workaround/proguard-project.txt
3230
oc_framework/proguard-project.txt
3331
oc_framework-test-project/proguard-project.txt
3432
tests/proguard-project.txt

CHANGELOG.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,20 @@
1+
## 2.10.0 (March 2018)
2+
- Android 9 (P) support (contribution)
3+
- Allow light filtering apps (optional)
4+
- Show additional info (user ID, email) when sharing with users with same display name
5+
- Support more options to enforce password when sharing publicly
6+
- Select all and inverse when uploading files (contribution)
7+
- Sorting options in sharing view (contribution)
8+
- Batched notifications for file deletions (contribution)
9+
- Commit hash in settings (contribution)
10+
- UI improvements, including:
11+
+ Disable log in button when credentials are empty (contribution)
12+
+ Warning to properly set camera folder in camera uploads
13+
- Bug fixes, including:
14+
+ Some camera upload issues in Android 9 (P) (contribution)
15+
+ Fix eye icon not visible to show/hide password in public shares (contribution)
16+
+ Fix welcome wizard rotation (contribution)
17+
118
## 2.10.0 beta v1 (February 2018)
219
- Android 9 (P) support (contribution)
320
- Select all and inverse when uploading files (contribution)

doc/workaround_icon-hires.png

-121 KB
Binary file not shown.

doc/workaround_icon-playstore.png

-25.7 KB
Binary file not shown.

doc/workaround_icon.svg

Lines changed: 0 additions & 77 deletions
This file was deleted.

owncloudApp/build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,11 @@ android {
6060
compileSdkVersion 28
6161

6262
defaultConfig {
63-
minSdkVersion 15
63+
minSdkVersion 19
6464
targetSdkVersion 28
6565

66-
versionCode = 20900400
67-
versionName = "2.10.0-beta.1"
66+
versionCode = 21000000
67+
versionName = "2.10.0"
6868

6969
buildConfigField "String", gitRemote, "\"" + getGitOriginRemote() + "\""
7070
buildConfigField "String", commitSHA1, "\"" + getLatestGitHash() + "\""

owncloudApp/src/main/AndroidManifest.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -191,12 +191,6 @@
191191
android:exported="true"
192192
android:launchMode="singleTask"
193193
android:theme="@style/Theme.ownCloud.Authenticator">
194-
<intent-filter>
195-
<action android:name="com.owncloud.android.workaround.accounts.CREATE" />
196-
197-
<category android:name="android.intent.category.DEFAULT" />
198-
</intent-filter>
199-
200194
<intent-filter>
201195
<action android:name="android.intent.action.VIEW" />
202196

owncloudApp/src/main/java/com/owncloud/android/files/services/FileUploader.java

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,9 @@
8484
import java.util.Map;
8585
import java.util.Vector;
8686

87+
import static com.owncloud.android.operations.UploadFileOperation.CREATED_AS_CAMERA_UPLOAD_PICTURE;
88+
import static com.owncloud.android.operations.UploadFileOperation.CREATED_AS_CAMERA_UPLOAD_VIDEO;
89+
8790
/**
8891
* Service for uploading files. Invoke using context.startService(...).
8992
*
@@ -282,28 +285,33 @@ public int onStartCommand(Intent intent, int flags, int startId) {
282285
Log_OC.d(TAG, "Starting command with id " + startId);
283286

284287
int createdBy = intent.getIntExtra(KEY_CREATED_BY, UploadFileOperation.CREATED_BY_USER);
285-
288+
boolean isCameraUploadFile =
289+
createdBy == CREATED_AS_CAMERA_UPLOAD_PICTURE || createdBy == CREATED_AS_CAMERA_UPLOAD_VIDEO;
286290
boolean isAvailableOfflineFile = intent.getBooleanExtra(KEY_IS_AVAILABLE_OFFLINE_FILE, false);
287291
boolean isRequestedFromWifiBackEvent = intent.getBooleanExtra(
288292
KEY_REQUESTED_FROM_WIFI_BACK_EVENT, false
289293
);
290294

291-
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
295+
if ((isCameraUploadFile || isAvailableOfflineFile || isRequestedFromWifiBackEvent) &&
296+
Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
292297
/*
293298
* After calling startForegroundService method from {@link TransferRequester} for camera uploads or
294299
* available offline, we have to call this within five seconds after the service is created to avoid
295300
* an error
296301
*/
297302
Log_OC.d(TAG, "Starting FileUploader service in foreground");
298303
mNotificationBuilder
299-
.setOngoing(true)
300-
.setSmallIcon(R.drawable.notification_icon)
301-
.setTicker(getString(R.string.uploader_upload_in_progress_ticker))
302-
.setContentTitle(getString(R.string.uploader_upload_in_progress_ticker))
303-
.setProgress(100, 0, false)
304-
.setContentText(String.format(getString(R.string.uploader_upload_in_progress_content), 0, ""))
305304
.setChannelId(UPLOAD_NOTIFICATION_CHANNEL_ID)
306-
.setWhen(System.currentTimeMillis());
305+
.setSmallIcon(R.drawable.notification_icon);
306+
307+
if (isCameraUploadFile) {
308+
mNotificationBuilder.setContentTitle(getString(R.string.uploader_upload_camera_upload_files));
309+
} else if (isAvailableOfflineFile) {
310+
mNotificationBuilder.setContentTitle(getString(R.string.uploader_upload_available_offline_files));
311+
} else if (isRequestedFromWifiBackEvent) {
312+
mNotificationBuilder.setContentTitle(getString(R.string.uploader_upload_requested_from_wifi_files));
313+
}
314+
307315
startForeground(141, mNotificationBuilder.build());
308316
}
309317

0 commit comments

Comments
 (0)