Skip to content

Commit 7de75a2

Browse files
committed
feat: add content description to all XML elements in space list item
1 parent 1e0a0d8 commit 7de75a2

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

owncloudApp/src/main/res/layout/spaces_list_item.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@
5151
android:layout_width="match_parent"
5252
android:layout_height="@dimen/spaces_thumbnail_height"
5353
android:scaleType="centerCrop"
54-
android:src="@drawable/ic_spaces" />
54+
android:src="@drawable/ic_spaces"
55+
android:contentDescription="@string/content_description_space_image"/>
5556

5657
<View
5758
android:layout_width="match_parent"
@@ -73,6 +74,7 @@
7374
android:textColor="@color/textColor"
7475
android:textSize="18sp"
7576
android:textStyle="bold"
77+
android:contentDescription="@string/content_description_space_name"
7678
tools:text="Name" />
7779

7880
<ImageView
@@ -84,6 +86,7 @@
8486
android:clickable="true"
8587
android:focusable="true"
8688
android:background="?android:attr/selectableItemBackground"
89+
android:contentDescription="@string/content_description_space_three_dot_menu"
8790
app:layout_constraintEnd_toEndOf="parent"
8891
app:layout_constraintTop_toTopOf="parent"
8992
app:layout_constraintBottom_toBottomOf="parent"/>
@@ -99,6 +102,7 @@
99102
android:singleLine="true"
100103
android:textColor="@color/textColor"
101104
android:textSize="15sp"
105+
android:contentDescription="@string/content_description_space_subtitle"
102106
tools:text="Subtitle" />
103107

104108
</LinearLayout>

owncloudApp/src/main/res/values/strings.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -820,6 +820,10 @@
820820
<string name="content_description_sort_by_name_ascending">Sort by %1$s ascending</string>
821821
<string name="content_description_sort_by_name_descending">Sort by %1$s descending</string>
822822
<string name="content_description_create_new_folder">Create new folder</string>
823+
<string name="content_description_space_image">Space image</string>
824+
<string name="content_description_space_name">Space name</string>
825+
<string name="content_description_space_three_dot_menu">Space three-dot menu</string>
826+
<string name="content_description_space_subtitle">Space subtitle</string>
823827

824828
<string name="create_shortcut_dialog_title">Create a shortcut</string>
825829
<string name="create_shortcut_dialog_url">URL</string>

0 commit comments

Comments
 (0)