fix: parse link response to show member option in all spaces

Author: joragua

owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/spaces/responses/SpacesResponse.kt

@@ -104,10 +104,16 @@ data class SpecialFolderResponse(
 
 @JsonClass(generateAdapter = true)
 data class PermissionsResponse(
+    // Member response
     val expirationDateTime: String?,
-    val grantedToV2: GrantedToV2Response,
+    val grantedToV2: GrantedToV2Response?,
     val id: String?,
-    val roles: List<String>
+    val roles: List<String>?,
+
+    // Link response
+    val createDateTime: String?,
+    val hasPassword: Boolean?,
+    val link: LinkInfoResponse?
 )
 
 @JsonClass(generateAdapter = true)
@@ -132,3 +138,14 @@ data class SpacePermissionsResponse(
     val members: List<PermissionsResponse>
 )
 
+@JsonClass(generateAdapter = true)
+data class LinkInfoResponse(
+    @Json(name = "@libre.graph.displayName")
+    val displayName: String,
+    @Json(name = "@libre.graph.quickLink")
+    val quickLink: Boolean,
+    val preventsDownload: Boolean,
+    val type: String,
+    val webUrl: String,
+)
+

owncloudData/src/main/java/com/owncloud/android/data/spaces/datasources/implementation/OCRemoteSpacesDataSource.kt

@@ -202,12 +202,13 @@ class OCRemoteSpacesDataSource(
                         displayName = spaceRoleResponse.displayName
                     )
                 },
-                members = members.map { spaceMemberResponse ->
+                members = members.filter { it.grantedToV2 != null }.map { spaceMemberResponse ->
                     SpaceMember (
                         id = spaceMemberResponse.id ?: "",
                         expirationDateTime = spaceMemberResponse.expirationDateTime,
-                        displayName = spaceMemberResponse.grantedToV2.user?.displayName ?: spaceMemberResponse.grantedToV2.group?.displayName ?: "",
-                        roles = spaceMemberResponse.roles
+                        displayName = spaceMemberResponse.grantedToV2?.user?.displayName
+                            ?: spaceMemberResponse.grantedToV2?.group?.displayName ?: "",
+                        roles = spaceMemberResponse.roles ?: emptyList()
                     )
                 }
             )
@@ -216,9 +217,9 @@ class OCRemoteSpacesDataSource(
         private fun getRoleForUser(root: RootResponse, userId: String, userGroups: List<String>): String? {
             val priorityOrder = listOf(MANAGER_ROLE, EDITOR_ROLE, VIEWER_ROLE)
             val matchingPermissions = root.permissions.orEmpty().filter { permission ->
-                permission.grantedToV2.user?.id == userId || permission.grantedToV2.group?.id in userGroups
+                permission.grantedToV2?.user?.id == userId || permission.grantedToV2?.group?.id in userGroups
             }
-            return matchingPermissions.flatMap { it.roles }.minByOrNull { priorityOrder.indexOf(it) }
+            return matchingPermissions.flatMap { it.roles.orEmpty() }.minByOrNull { priorityOrder.indexOf(it) }
         }
     }
 }