refactor: remove unnecessary XML elements and auxiliary method for observing view model flows

Author: joragua

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersFragment.kt

@@ -64,7 +64,17 @@ class SpaceMembersFragment : Fragment() {
             adapter = spaceMembersAdapter
         }
 
-        subscribeToViewModels()
+        collectLatestLifecycleFlow(spaceMembersViewModel.spaceMembers) { event ->
+            event?.let {
+                when (val uiResult = event.peekContent()) {
+                    is UIResult.Success -> {
+                        uiResult.data?.let { spaceMembersAdapter.setSpaceMembers(it) }
+                    }
+                    is UIResult.Loading -> { }
+                    is UIResult.Error -> { }
+                }
+            }
+        }
 
         val currentSpace = requireArguments().getParcelable<OCSpace>(ARG_CURRENT_SPACE) ?: return
         binding.apply {
@@ -83,21 +93,6 @@ class SpaceMembersFragment : Fragment() {
                 }
             }
         }
-
-    }
-
-    private fun subscribeToViewModels() {
-        collectLatestLifecycleFlow(spaceMembersViewModel.spaceMembers) { event ->
-            event?.let {
-                when (val uiResult = event.peekContent()) {
-                    is UIResult.Success -> {
-                        uiResult.data?.let { spaceMembersAdapter.setSpaceMembers(it) }
-                    }
-                    is UIResult.Loading -> { }
-                    is UIResult.Error -> { }
-                }
-            }
-        }
     }
 
     companion object {

owncloudApp/src/main/res/layout/members_fragment.xml

@@ -109,17 +109,6 @@
                 android:visibility="visible"
                 tools:visibility="visible"/>
 
-            <TextView
-                android:id="@+id/members_list_empty"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:paddingBottom="@dimen/standard_padding"
-                android:paddingStart="@dimen/standard_half_padding"
-                android:paddingTop="@dimen/standard_padding"
-                android:text="@string/share_no_users"
-                android:textSize="15sp"
-                android:visibility="gone"/>
-
         </LinearLayout>
 
     </LinearLayout>

owncloudData/src/main/java/com/owncloud/android/data/spaces/datasources/implementation/OCRemoteSpacesDataSource.kt

@@ -67,7 +67,8 @@ class OCRemoteSpacesDataSource(
 
     override fun getSpacePermissions(accountName: String, spaceId: String): List<String> {
         val spacePermissionsResponse = executeRemoteOperation {
-            clientManager.getSpacesService(accountName).getSpacePermissions(spaceId) }
+            clientManager.getSpacesService(accountName).getSpacePermissions(spaceId)
+        }
         return spacePermissionsResponse.actions
     }