fix: set space name, subtitle and menu dynamically for accessibility

Author: joragua

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListAdapter.kt

@@ -60,6 +60,10 @@ class SpacesListAdapter(
                 listener.onItemClick(space)
             }
             spacesListItemCard.setAccessibilityRole(className = Button::class.java)
+            spacesListItemName.contentDescription = holder.itemView.context.getString(R.string.content_description_space_name, space.name)
+            spacesThreeDotMenu.contentDescription = holder.itemView.context.getString(R.string.content_description_space_three_dot_menu, space.name)
+            spacesListItemSubtitle.contentDescription = holder.itemView.context.getString(R.string.content_description_space_subtitle,
+                space.description)
 
             if (space.isPersonal && !isMultiPersonal) {
                 spacesListItemName.text = holder.itemView.context.getString(R.string.bottom_nav_personal)

owncloudApp/src/main/res/layout/spaces_list_item.xml

@@ -74,7 +74,6 @@
                     android:textColor="@color/textColor"
                     android:textSize="18sp"
                     android:textStyle="bold"
-                    android:contentDescription="@string/content_description_space_name"
                     tools:text="Name" />
 
                 <ImageView
@@ -86,7 +85,6 @@
                     android:clickable="true"
                     android:focusable="true"
                     android:background="?android:attr/selectableItemBackground"
-                    android:contentDescription="@string/content_description_space_three_dot_menu"
                     app:layout_constraintEnd_toEndOf="parent"
                     app:layout_constraintTop_toTopOf="parent"
                     app:layout_constraintBottom_toBottomOf="parent"/>
@@ -102,7 +100,6 @@
                 android:singleLine="true"
                 android:textColor="@color/textColor"
                 android:textSize="15sp"
-                android:contentDescription="@string/content_description_space_subtitle"
                 tools:text="Subtitle" />
 
         </LinearLayout>

owncloudApp/src/main/res/values/strings.xml

@@ -821,9 +821,9 @@
     <string name="content_description_sort_by_name_descending">Sort by %1$s descending</string>
     <string name="content_description_create_new_folder">Create new folder</string>
     <string name="content_description_space_image">Space image</string>
-    <string name="content_description_space_name">Space name</string>
-    <string name="content_description_space_three_dot_menu">Space menu</string>
-    <string name="content_description_space_subtitle">Space subtitle</string>
+    <string name="content_description_space_name">%1$s space name</string>
+    <string name="content_description_space_three_dot_menu">%1$s space menu</string>
+    <string name="content_description_space_subtitle">%1$s space subtitle</string>
 
     <string name="create_shortcut_dialog_title">Create a shortcut</string>
     <string name="create_shortcut_dialog_url">URL</string>