Merge pull request #4448 from owncloud/feature/info_and_relationships_headings

[a11y] 11.1.3.1a Info and relationships

Author: Aitorbp

CHANGELOG.md

@@ -32,12 +32,34 @@ ownCloud admins and users.
 
 ## Summary
 
+* Bugfix - Shares in non-root are updated correctly: [#4432](https://github.com/owncloud/android/issues/4432)
+* Enhancement - Improved accessibility of information and relationships: [#4362](https://github.com/owncloud/android/issues/4362)
 * Enhancement - Changed the color of some elements to improve accessibility: [#4364](https://github.com/owncloud/android/issues/4364)
 * Enhancement - Improved SearchView accessibility: [#4365](https://github.com/owncloud/android/issues/4365)
 * Enhancement - Hardware keyboard support: [#4438](https://github.com/owncloud/android/pull/4438)
 
 ## Details
 
+* Bugfix - Shares in non-root are updated correctly: [#4432](https://github.com/owncloud/android/issues/4432)
+
+   The items of the "Share" view are updated instantly when create/edit a link or
+   share with users or groups in a non-root file.
+
+   https://github.com/owncloud/android/issues/4432
+   https://github.com/owncloud/android/pull/4435
+
+* Enhancement - Improved accessibility of information and relationships: [#4362](https://github.com/owncloud/android/issues/4362)
+
+   Headings have been added to the following views: Share, Edit/Create Share Link,
+   Standard Toolbar and Manage Accounts. The filename input field and the two
+   switches are now linked to their labels. The 'contentDescription' attributes of
+   the buttons in the Edit/Create Share Link view have also been updated.
+
+   https://github.com/owncloud/android/issues/4362
+   https://github.com/owncloud/android/issues/4363
+   https://github.com/owncloud/android/issues/4371
+   https://github.com/owncloud/android/pull/4448
+
 * Enhancement - Changed the color of some elements to improve accessibility: [#4364](https://github.com/owncloud/android/issues/4364)
 
    The color of some UI elements has been changed to meet minimum color contrast

changelog/unreleased/4448

@@ -0,0 +1,10 @@
+Enhancement: Improved accessibility of information and relationships
+
+Headings have been added to the following views: Share, Edit/Create Share Link, Standard Toolbar and Manage Accounts.
+The filename input field and the two switches are now linked to their labels.
+The 'contentDescription' attributes of the buttons in the Edit/Create Share Link view have also been updated.
+
+https://github.com/owncloud/android/issues/4362
+https://github.com/owncloud/android/issues/4363
+https://github.com/owncloud/android/issues/4371
+https://github.com/owncloud/android/pull/4448

owncloudApp/src/main/res/layout/manage_accounts_dialog.xml

@@ -33,6 +33,7 @@
                     android:src="@drawable/ic_cross_manage_accounts"
                     android:layout_marginVertical="13dp"
                     android:layout_marginStart="13dp"
+                    android:contentDescription="@string/drawer_close"
                     app:layout_constraintBottom_toBottomOf="parent"
                     app:layout_constraintStart_toStartOf="parent"
                     app:layout_constraintTop_toTopOf="parent"
@@ -47,6 +48,7 @@
                     android:textColor="@color/white"
                     android:textSize="18sp"
                     android:textStyle="bold"
+                    android:accessibilityHeading="true"
                     app:layout_constraintBottom_toBottomOf="parent"
                     app:layout_constraintEnd_toEndOf="parent"
                     app:layout_constraintStart_toStartOf="parent"

owncloudApp/src/main/res/layout/owncloud_toolbar.xml

@@ -95,6 +95,9 @@
         android:theme="@style/ownCloud.Appbar"
         android:visibility="gone"
         android:layout_marginEnd="@dimen/standard_margin"
+        android:focusable="true"
+        android:focusableInTouchMode="false"
+        android:accessibilityHeading="true"
         app:navigationContentDescription="@string/common_back"
         app:popupTheme="?attr/actionBarPopupTheme" />
 </com.google.android.material.appbar.AppBarLayout>

owncloudApp/src/main/res/layout/share_file_layout.xml

@@ -105,7 +105,8 @@
                     android:text="@string/share_with_user_section_title"
                     android:textAllCaps="true"
                     android:textColor="@color/white"
-                    android:textStyle="bold" />
+                    android:textStyle="bold"
+                    android:accessibilityHeading="true"/>
 
                 <ImageButton
                     android:id="@+id/addUserButton"
@@ -159,7 +160,8 @@
                     android:text="@string/share_via_link_section_title"
                     android:textAllCaps="true"
                     android:textColor="@color/white"
-                    android:textStyle="bold" />
+                    android:textStyle="bold"
+                    android:accessibilityHeading="true"/>
 
                 <ImageButton
                     android:id="@+id/addPublicLinkButton"

owncloudApp/src/main/res/layout/share_public_dialog.xml

@@ -11,7 +11,8 @@
         android:layout_height="wrap_content"
         android:padding="@dimen/standard_half_padding"
         android:text="@string/share_via_link_create_title"
-        android:textAppearance="@android:style/TextAppearance.Material.DialogWindowTitle" />
+        android:textAppearance="@android:style/TextAppearance.Material.DialogWindowTitle"
+        android:accessibilityHeading="true"/>
 
     <ScrollView
         android:layout_width="match_parent"
@@ -30,6 +31,7 @@
                 android:orientation="horizontal">
 
                 <TextView
+                    android:labelFor="@+id/shareViaLinkNameValue"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:padding="@dimen/standard_half_padding"
@@ -90,6 +92,7 @@
 
                 <TextView
                     android:id="@+id/shareViaLinkPasswordLabel"
+                    android:labelFor="@+id/shareViaLinkPasswordSwitch"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:layout_alignParentStart="true"
@@ -280,6 +283,7 @@
 
                 <TextView
                     android:id="@+id/shareViaLinkExpirationLabel"
+                    android:labelFor="@+id/shareViaLinkExpirationSwitch"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:layout_alignParentStart="true"
@@ -354,7 +358,7 @@
                         android:layout_width="match_parent"
                         android:layout_height="wrap_content"
                         android:layout_weight="1"
-                        android:contentDescription="shareAddPublicLinkCancelButton"
+                        android:contentDescription="@string/share_cancel_public_link_button"
                         android:text="@string/share_cancel_public_link_button"
                         android:theme="@style/Button.Primary" />
 
@@ -364,7 +368,7 @@
                         android:layout_width="match_parent"
                         android:layout_height="wrap_content"
                         android:layout_weight="1"
-                        android:contentDescription="shareAddPublicLinkConfirmButton"
+                        android:contentDescription="@string/share_confirm_public_link_button"
                         android:text="@string/share_confirm_public_link_button"
                         android:theme="@style/Button.Primary" />
 

owncloudApp/src/main/res/layout/share_public_link_item.xml

@@ -22,7 +22,6 @@
     <LinearLayout
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:longClickable="true"
         android:orientation="horizontal"
         android:weightSum="1">
 

owncloudApp/src/main/res/layout/share_user_item.xml

@@ -26,8 +26,7 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:orientation="horizontal"
-        android:weightSum="1"
-        android:longClickable="true">
+        android:weightSum="1">
 
         <ImageView
             android:layout_width="wrap_content"