feat: merge options from extends tsconfig.json (#375)

Co-authored-by: Boshen <[email protected]>

Author: IWANABETHATGUY

fixtures/tsconfig/cases/merge_compiler_options/base-tsconfig.json

@@ -0,0 +1,9 @@
+{
+  "compilerOptions": {
+    "experimentalDecorators": true,
+    "jsx": "react-jsx",
+    "jsxFactory": "h",
+    "jsxFragmentFactory": "Fragment",
+    "jsxImportSource": "xxx"
+  }
+}

fixtures/tsconfig/cases/merge_compiler_options/tsconfig.json

@@ -0,0 +1,3 @@
+{
+  "extends": "./base-tsconfig"
+}

fixtures/tsconfig/cases/no_merge_compiler_options/base-tsconfig.json

@@ -0,0 +1,9 @@
+{
+  "compilerOptions": {
+    "experimentalDecorators": false,
+    "jsx": "aaa",
+    "jsxFactory": "bbb",
+    "jsxFragmentFactory": "ccc",
+    "jsxImportSource": "ddd"
+  }
+}

fixtures/tsconfig/cases/no_merge_compiler_options/tsconfig.json

@@ -0,0 +1,10 @@
+{
+  "extends": "./base-tsconfig",
+  "compilerOptions": {
+    "experimentalDecorators": true,
+    "jsx": "react-jsx",
+    "jsxFactory": "h",
+    "jsxFragmentFactory": "Fragment",
+    "jsxImportSource": "xxx"
+  }
+}

src/tests/tsconfig_paths.rs

@@ -209,6 +209,32 @@ fn test_paths_and_base_url() {
     }
 }
 
+#[test]
+fn test_merge_tsconfig() {
+    let resolver = Resolver::default();
+    let dir = super::fixture_root().join("tsconfig/cases/merge_compiler_options");
+    let resolution = resolver.resolve_tsconfig(&dir).expect("resolved");
+    let compiler_options = resolution.compiler_options();
+    assert_eq!(compiler_options.experimental_decorators, Some(true));
+    assert_eq!(compiler_options.jsx, Some("react-jsx".to_string()));
+    assert_eq!(compiler_options.jsx_factory, Some("h".to_string()));
+    assert_eq!(compiler_options.jsx_fragment_factory, Some("Fragment".to_string()));
+    assert_eq!(compiler_options.jsx_import_source, Some("xxx".to_string()));
+}
+
+#[test]
+fn test_no_merge_tsconfig() {
+    let resolver = Resolver::default();
+    let dir = super::fixture_root().join("tsconfig/cases/no_merge_compiler_options");
+    let resolution = resolver.resolve_tsconfig(&dir).expect("resolved");
+    let compiler_options = resolution.compiler_options();
+    assert_eq!(compiler_options.experimental_decorators, Some(true));
+    assert_eq!(compiler_options.jsx, Some("react-jsx".to_string()));
+    assert_eq!(compiler_options.jsx_factory, Some("h".to_string()));
+    assert_eq!(compiler_options.jsx_fragment_factory, Some("Fragment".to_string()));
+    assert_eq!(compiler_options.jsx_import_source, Some("xxx".to_string()));
+}
+
 // Template variable ${configDir} for substitution of config files directory path
 // https://github.com/microsoft/TypeScript/pull/58042
 #[test]

src/tsconfig.rs

@@ -104,6 +104,38 @@ pub trait TsConfig: Sized {
                 compiler_options.set_base_url(base_url.to_path_buf());
             }
         }
+
+        if compiler_options.experimental_decorators().is_none() {
+            if let Some(experimental_decorators) =
+                tsconfig.compiler_options().experimental_decorators()
+            {
+                compiler_options.set_experimental_decorators(*experimental_decorators);
+            }
+        }
+
+        if compiler_options.jsx().is_none() {
+            if let Some(jsx) = tsconfig.compiler_options().jsx() {
+                compiler_options.set_jsx(jsx.to_string());
+            }
+        }
+
+        if compiler_options.jsx_factory().is_none() {
+            if let Some(jsx_factory) = tsconfig.compiler_options().jsx_factory() {
+                compiler_options.set_jsx_factory(jsx_factory.to_string());
+            }
+        }
+
+        if compiler_options.jsx_fragment_factory().is_none() {
+            if let Some(jsx_fragment_factory) = tsconfig.compiler_options().jsx_fragment_factory() {
+                compiler_options.set_jsx_fragment_factory(jsx_fragment_factory.to_string());
+            }
+        }
+
+        if compiler_options.jsx_import_source().is_none() {
+            if let Some(jsx_import_source) = tsconfig.compiler_options().jsx_import_source() {
+                compiler_options.set_jsx_import_source(jsx_import_source.to_string());
+            }
+        }
     }
 
     /// Resolves the given `specifier` within the project configured by this
@@ -232,6 +264,46 @@ pub trait CompilerOptions {
 
     /// Sets the path base.
     fn set_paths_base(&mut self, paths_base: PathBuf);
+
+    /// Whether to enable experimental decorators.
+    fn experimental_decorators(&self) -> Option<&bool> {
+        None
+    }
+
+    /// Sets whether to enable experimental decorators.
+    fn set_experimental_decorators(&mut self, _experimental_decorators: bool) {}
+
+    /// JSX.
+    fn jsx(&self) -> Option<&str> {
+        None
+    }
+
+    /// Sets JSX.
+    fn set_jsx(&mut self, _jsx: String) {}
+
+    /// JSX factory.
+    fn jsx_factory(&self) -> Option<&str> {
+        None
+    }
+
+    /// Sets JSX factory.
+    fn set_jsx_factory(&mut self, _jsx_factory: String) {}
+
+    /// JSX fragment factory.
+    fn jsx_fragment_factory(&self) -> Option<&str> {
+        None
+    }
+
+    /// Sets JSX fragment factory.
+    fn set_jsx_fragment_factory(&mut self, _jsx_fragment_factory: String) {}
+
+    /// JSX import source.
+    fn jsx_import_source(&self) -> Option<&str> {
+        None
+    }
+
+    /// Sets JSX import source.
+    fn set_jsx_import_source(&mut self, _jsx_import_source: String) {}
 }
 
 /// Project Reference.

src/tsconfig_serde.rs

@@ -155,6 +155,46 @@ impl CompilerOptions for CompilerOptionsSerde {
     fn set_paths_base(&mut self, paths_base: PathBuf) {
         self.paths_base = paths_base;
     }
+
+    fn experimental_decorators(&self) -> Option<&bool> {
+        self.experimental_decorators.as_ref()
+    }
+
+    fn set_experimental_decorators(&mut self, experimental_decorators: bool) {
+        self.experimental_decorators = Some(experimental_decorators);
+    }
+
+    fn jsx(&self) -> Option<&str> {
+        self.jsx.as_deref()
+    }
+
+    fn set_jsx(&mut self, jsx: String) {
+        self.jsx = Some(jsx);
+    }
+
+    fn jsx_factory(&self) -> Option<&str> {
+        self.jsx_factory.as_deref()
+    }
+
+    fn set_jsx_factory(&mut self, jsx_factory: String) {
+        self.jsx_factory = Some(jsx_factory);
+    }
+
+    fn jsx_fragment_factory(&self) -> Option<&str> {
+        self.jsx_fragment_factory.as_deref()
+    }
+
+    fn set_jsx_fragment_factory(&mut self, jsx_fragment_factory: String) {
+        self.jsx_fragment_factory = Some(jsx_fragment_factory);
+    }
+
+    fn jsx_import_source(&self) -> Option<&str> {
+        self.jsx_import_source.as_deref()
+    }
+
+    fn set_jsx_import_source(&mut self, jsx_import_source: String) {
+        self.jsx_import_source = Some(jsx_import_source);
+    }
 }
 
 /// Value for the "extends" field.