refactor: add test cases for resolve alias value with fragment (#170)

Author: Boshen

src/lib.rs

@@ -880,22 +880,7 @@ impl<Fs: FileSystem> ResolverGeneric<Fs> {
                     AliasValue::Path(alias_value) => {
                         let new_specifier =
                             Specifier::parse(alias_value).map_err(ResolveError::Specifier)?;
-
-                        // `#` can be a fragment or a path, try fragment as path first
-                        if new_specifier.query.is_none() && new_specifier.fragment.is_some() {
-                            if let Some(path) = self.load_alias_value(
-                                cached_path,
-                                alias_key,
-                                alias_value, // pass in original alias value, not parsed
-                                specifier,
-                                ctx,
-                                &mut should_stop,
-                            )? {
-                                return Ok(Some(path));
-                            }
-                        }
-
-                        // Then try path without query and fragment
+                        // Resolve path without query and fragment
                         let old_query = ctx.query.clone();
                         let old_fragment = ctx.fragment.clone();
                         ctx.with_query_fragment(new_specifier.query, new_specifier.fragment);

src/tests/alias.rs

@@ -233,3 +233,34 @@ fn all_alias_values_are_not_found() {
     let resolution = resolver.resolve(&f, "m1/a.js");
     assert_eq!(resolution, Err(ResolveError::NotFound("m1/a.js".to_string())));
 }
+
+#[test]
+fn alias_fragment() {
+    let f = super::fixture();
+
+    let data = [
+        // enhanced-resolve has `#` prepended with a `\0`, they are removed from the
+        // following 3 expected test results.
+        // See https://github.com/webpack/enhanced-resolve#escaping
+        (
+            "handle fragment edge case (no fragment)",
+            "./no#fragment/#/#",
+            f.join("no#fragment/#/#.js"),
+        ),
+        ("handle fragment edge case (fragment)", "./no#fragment/#/", f.join("no.js#fragment/#/")),
+        (
+            "handle fragment escaping",
+            "./no\0#fragment/\0#/\0##fragment",
+            f.join("no#fragment/#/#.js#fragment"),
+        ),
+    ];
+
+    for (comment, request, expected) in data {
+        let resolver = Resolver::new(ResolveOptions {
+            alias: vec![("foo".to_string(), vec![AliasValue::Path(request.to_string())])],
+            ..ResolveOptions::default()
+        });
+        let resolved_path = resolver.resolve(&f, "foo").map(|r| r.full_path());
+        assert_eq!(resolved_path, Ok(expected), "{comment} {request}");
+    }
+}