fix(formatter/sort-imports)!: Change default order to natural with natord crate (#15828)

Part of #14253

Change the default order type from `alphabetical` to `natural`.

In the original JS implementation, `alphabetical` sort uses the built-in `localeCompare()` function, but this does not exist in Rust.

I have therefore changed the default to `natural` because:

- Adding a crate to handle locale would be excessive
- `prettier-plugin-sort-imports` also uses natural sorting

Author: leaysgur

Cargo.lock

@@ -30,6 +30,7 @@ oxc_syntax = { workspace = true }
 
 cow-utils = { workspace = true }
 json-strip-comments = { workspace = true }
+natord = "1.0.9"
 phf = { workspace = true, features = ["macros"] }
 rustc-hash = { workspace = true }
 schemars = { workspace = true }

crates/oxc_formatter/Cargo.toml

@@ -266,7 +266,8 @@ fn sort_imports(imports: &mut [SortableImport], options: &options::SortImports)
         }
 
         // Within the same group, sort by source respecting the order option
-        let source_ord = imports[a].normalized_source.cmp(&imports[b].normalized_source);
+        let source_ord =
+            natord::compare(&imports[a].normalized_source, &imports[b].normalized_source);
         if options.order.is_desc() { source_ord.reverse() } else { source_ord }
     });
 

crates/oxc_formatter/src/ir_transform/sort_imports/mod.rs

@@ -38,7 +38,7 @@ import * as c from "c";
 import d from "d";
 "#,
     );
-    // Alphabetical ASC order by default
+    // Natural ASC order by default
     assert_format(
         r#"
 import { log } from "./log";
@@ -49,9 +49,9 @@ import { log2 } from "./log2";
         r#"{ "experimentalSortImports": {} }"#,
         r#"
 import { log } from "./log";
-import { log10 } from "./log10";
 import { log1p } from "./log1p";
 import { log2 } from "./log2";
+import { log10 } from "./log10";
 "#,
     );
     // Dynamic imports should not affect sorting
@@ -612,7 +612,7 @@ import B from "b";
 
 #[test]
 fn should_sort_by_order() {
-    // Z-A
+    // Z-A (natural order reversed)
     assert_format(
         r#"
 import { log } from "./log";
@@ -622,13 +622,13 @@ import { log2 } from "./log2";
 "#,
         r#"{ "experimentalSortImports": { "order": "desc" } }"#,
         r#"
+import { log10 } from "./log10";
 import { log2 } from "./log2";
 import { log1p } from "./log1p";
-import { log10 } from "./log10";
 import { log } from "./log";
 "#,
     );
-    // A-Z - default
+    // A-Z - default (natural order)
     assert_format(
         r#"
 import { log } from "./log";
@@ -639,9 +639,9 @@ import { log2 } from "./log2";
         r#"{ "experimentalSortImports": { "order": "asc" } }"#,
         r#"
 import { log } from "./log";
-import { log10 } from "./log10";
 import { log1p } from "./log1p";
 import { log2 } from "./log2";
+import { log10 } from "./log10";
 "#,
     );
     assert_format(
@@ -654,9 +654,9 @@ import { log2 } from "./log2";
         r#"{ "experimentalSortImports": {} }"#,
         r#"
 import { log } from "./log";
-import { log10 } from "./log10";
 import { log1p } from "./log1p";
 import { log2 } from "./log2";
+import { log10 } from "./log10";
 "#,
     );
 }