Commit 03f5729
committed
refactor(formatter): Remove unused multiline comment check in ternary (#16230)
Follow up #16224
> - Biome
> - The same logic still exists
> - https://github.com/biomejs/biome/blob/e7e0f6c14df92d83d08f86b1e57fc82b4df775b7/crates/biome_js_formatter/src/utils/conditional.rs#L197
> - In either case, the test did not fail
> - always returning `false`
> - removing related code like our diff above
> - Prettier
> - The most relevant lines are here
> - https://github.com/prettier/prettier/blob/fd69335e513232c9b7aad78c93b42d8d3dd00ae7/src/language-js/print/ternary-old.js#L326-L344
> - As you expected, if change this to `const shouldBreak = false`, the test did not fail!
From #16224 (comment)1 parent ac3a92e commit 03f5729
1 file changed
+1
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
342 | 342 | | |
343 | 343 | | |
344 | 344 | | |
345 | | - | |
346 | | - | |
347 | | - | |
348 | | - | |
349 | | - | |
350 | | - | |
351 | | - | |
352 | 345 | | |
353 | 346 | | |
354 | 347 | | |
| |||
502 | 495 | | |
503 | 496 | | |
504 | 497 | | |
505 | | - | |
506 | 498 | | |
507 | 499 | | |
508 | 500 | | |
| |||
580 | 572 | | |
581 | 573 | | |
582 | 574 | | |
583 | | - | |
| 575 | + | |
584 | 576 | | |
585 | | - | |
586 | | - | |
587 | | - | |
588 | 577 | | |
589 | 578 | | |
590 | 579 | | |
| |||
0 commit comments