ci(linter/plugins): lint apps/oxlint with oxlint (#15887)

2nd try at #14573. Run oxlint on oxlint. Linter inception.

Author: overlookmotel

.github/workflows/ci.yml

@@ -274,6 +274,11 @@ jobs:
       - run: cargo lint -- -D warnings
       - run: cargo lint --profile dev-no-debug-assertions -- -D warnings
       - run: RUSTDOCFLAGS='-D warnings' cargo doc --no-deps --document-private-items
+      # Need to build Oxlint's JS bundle before linting `apps/oxlint`, because the tests reference
+      # the `index.d.ts` file produced by TSDown. Type-aware rules rely on this `.d.ts` file being present.
+      - name: Build Oxlint
+        working-directory: apps/oxlint
+        run: pnpm run build-js
       - run: node --run lint
 
   conformance:

apps/oxlint/src-js/plugins/context.ts

@@ -315,7 +315,7 @@ export interface Context extends FileContext {
   /**
    * Report an error/warning.
    */
-  report(diagnostic: Diagnostic): void;
+  report(this: void, diagnostic: Diagnostic): void;
 }
 
 /**
@@ -367,7 +367,7 @@ export function createContext(fullRuleName: string, ruleDetails: RuleDetails): R
      * @param diagnostic - Diagnostic object
      * @throws {TypeError} If `diagnostic` is invalid
      */
-    report(diagnostic: Diagnostic): void {
+    report(this: void, diagnostic: Diagnostic): void {
       // Delegate to `report` implementation shared between all rules, passing rule-specific details (`RuleDetails`)
       report(diagnostic, ruleDetails);
     },

apps/oxlint/test/compile-visitor.test.ts

@@ -1,3 +1,5 @@
+// oxlint-disable jest/no-conditional-expect
+
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 import { LEAF_NODE_TYPES_COUNT, NODE_TYPE_IDS_MAP } from '../src-js/generated/type_ids.js';
 import {
@@ -49,8 +51,8 @@ describe('compile visitor', () => {
   });
 
   it('accepts unknown visitor key', () => {
-    addVisitorToCompiled({ Foo() {} });
-    addVisitorToCompiled({ 'Foo:exit'() {} });
+    expect(() => addVisitorToCompiled({ Foo() {} })).not.toThrow();
+    expect(() => addVisitorToCompiled({ 'Foo:exit'() {} })).not.toThrow();
   });
 
   describe('registers enter visitor', () => {

apps/oxlint/test/e2e.test.ts

@@ -1,3 +1,5 @@
+// oxlint-disable jest/expect-expect
+
 import fs from 'node:fs/promises';
 import { join as pathJoin } from 'node:path';
 import { describe, it } from 'vitest';

apps/oxlint/test/eslint-compat.test.ts

@@ -1,3 +1,5 @@
+// oxlint-disable jest/expect-expect
+
 import { join as pathJoin } from 'node:path';
 import { describe, it } from 'vitest';
 import { testFixtureWithCommand } from './utils.js';
@@ -19,6 +21,7 @@ async function testFixture(fixtureName: string): Promise<void> {
 }
 
 // These tests take longer than 5 seconds on CI, so increase timeout to 10 seconds
+// oxlint-disable-next-line jest/valid-describe-callback
 describe('ESLint compatibility', { timeout: 10_000 }, () => {
   it('`definePlugin` should work', async () => {
     await testFixture('definePlugin');

apps/oxlint/test/fixtures/estree/plugin.ts

@@ -1,3 +1,5 @@
+// oxlint-disable typescript/restrict-template-expressions
+
 import assert from 'node:assert';
 
 import type { Plugin } from '../../../dist/index.js';

apps/oxlint/test/fixtures/utf16_offsets/plugin.ts

@@ -1,3 +1,5 @@
+// oxlint-disable typescript/restrict-template-expressions
+
 import type { Plugin } from '../../../dist/index.js';
 
 const plugin: Plugin = {

oxlintrc.json

@@ -43,6 +43,7 @@
     "tasks/coverage/**",
     "crates/oxc_semantic/tests/**",
     "napi/minify/**", // TODO
-    "apps/oxlint" // TODO
+    "!apps/oxlint/test/fixtures/**",
+    "apps/oxlint/test/fixtures/*/files/**"
   ]
 }