Skip to content

Commit 18616c2

Browse files
committed
fix(oxlint): ignore fixtures dir for vitest (#14414)
not sure why, but I was getting this error: ``` ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Suites 4 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ FAIL fixtures/overrides_with_plugin/index.test.ts [ fixtures/overrides_with_plugin/index.test.ts ] ReferenceError: describe is not defined ❯ fixtures/overrides_with_plugin/index.test.ts:1:1 1| describe("", () => { | ^ 2| // ^ jest/no-valid-title error as explicitly set in the `.test.ts` override 3| ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/4]⎯ FAIL fixtures/eslintrc_vitest_replace/foo.test.js [ fixtures/eslintrc_vitest_replace/foo.test.js ] ReferenceError: test is not defined ❯ fixtures/eslintrc_vitest_replace/foo.test.js:1:1 1| test.skip('foo', () => { | ^ 2| // ... 3| }) ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/4]⎯ FAIL fixtures/issue_10394/foo.test.ts [ fixtures/issue_10394/foo.test.ts ] ReferenceError: describe is not defined ❯ fixtures/issue_10394/foo.test.ts:1:1 1| describe("", () => { | ^ 2| // 3| }); ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[3/4]⎯ FAIL fixtures/config_ignore_patterns/ignore_directory/tests/main.spec.js [ fixtures/config_ignore_patterns/ignore_directory/tests/main.spec.js ] Error: No test suite found in file /Users/cameron/github/Boshen/oxc/apps/oxlint/fixtures/config_ignore_patterns/ignore_directory/tests/main.spec.js ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[4/4]⎯ Test Files 4 failed | 3 passed (7) Tests 61 passed (61) Start at 16:31:02 Duration 2.88s ```
1 parent 83e7824 commit 18616c2

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

apps/oxlint/vitest.config.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1-
import { defineConfig } from 'vitest/config';
1+
import { configDefaults, defineConfig } from 'vitest/config';
22

3-
export default defineConfig({});
3+
export default defineConfig({
4+
test: {
5+
exclude: [...configDefaults.exclude, 'fixtures/**'],
6+
},
7+
});

0 commit comments

Comments
 (0)