Skip to content

Commit 2674748

Browse files
committed
Skip rules.test.ts in Playwright test group.
There's no reason to run this test as this is not testing a specific rule.
1 parent a00b4a4 commit 2674748

File tree

2 files changed

+5
-16
lines changed

2 files changed

+5
-16
lines changed

apps/oxlint/conformance/snapshots/playwright.md

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66

77
| Status | Count | % |
88
| ----------------- | ----- | ------ |
9-
| Total rules | 59 | 100.0% |
10-
| Fully passing | 57 | 96.6% |
9+
| Total rules | 58 | 100.0% |
10+
| Fully passing | 57 | 98.3% |
1111
| Partially passing | 1 | 1.7% |
1212
| Fully failing | 0 | 0.0% |
13-
| Load errors | 1 | 1.7% |
13+
| Load errors | 0 | 0.0% |
1414
| No tests run | 0 | 0.0% |
1515

1616
### Tests
@@ -297,16 +297,3 @@ AssertionError [ERR_ASSERTION]: Should have 1 error but had 0: []
297297
at runInvalidTestCase (apps/oxlint/dist/plugins-dev.js)
298298
at apps/oxlint/dist/plugins-dev.js
299299

300-
301-
## Load Errors
302-
303-
### `rules`
304-
305-
Error: Transform failed with 1 error:
306-
/Users/connorshea/code/oxc/apps/oxlint/conformance/submodules/playwright/src/rules/rules.test.ts:4:23: ERROR: Top-level await is currently not supported with the "cjs" output format
307-
at failureErrorWithLog (node_modules/.pnpm/esbuild@0.27.3/node_modules/esbuild/lib/main.js:1467:15)
308-
at node_modules/.pnpm/esbuild@0.27.3/node_modules/esbuild/lib/main.js:736:50
309-
at responseCallbacks.<computed> (node_modules/.pnpm/esbuild@0.27.3/node_modules/esbuild/lib/main.js:603:9)
310-
at handleIncomingPacket (node_modules/.pnpm/esbuild@0.27.3/node_modules/esbuild/lib/main.js:658:12)
311-
312-

apps/oxlint/conformance/src/groups/playwright.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ const group: TestGroup = {
1414

1515
transformTestFilename(filename: string) {
1616
if (!filename.endsWith(".test.ts")) return null;
17+
// `rules.test.ts` is a meta-test for plugin exports/README, not a rule test.
18+
if (filename === "rules.test.ts") return null;
1719
return filename.slice(0, -".test.ts".length);
1820
},
1921

0 commit comments

Comments
 (0)