refactor(vscode): add ToolInterface.getBinary (#16066)

The extension needs to check if the binaries are the same. Should probably never happen, but my first tests are targeting the same server and fails because of the same `oxc.X` command from the two language server.

Author: Sysix

editors/vscode/client/extension.ts

@@ -53,8 +53,18 @@ export async function activate(context: ExtensionContext) {
   configService.onConfigChange = async function onConfigChange(event) {
     await linter.onConfigChange(event, configService, statusBarItemHandler);
   };
+  const binaryPath = await linter.getBinary(context, outputChannel, configService);
 
-  await linter.activate(context, outputChannel, configService, statusBarItemHandler);
+  // For the linter this should never happen, but just in case.
+  if (!binaryPath) {
+    statusBarItemHandler.setColorAndIcon('statusBarItem.errorBackground', 'error');
+    statusBarItemHandler.updateToolTooltip('linter', 'Error: No valid oxc language server binary found.');
+    statusBarItemHandler.show();
+    outputChannel.error('No valid oxc language server binary found.');
+    return;
+  }
+
+  await linter.activate(context, binaryPath, outputChannel, configService, statusBarItemHandler);
   // Show status bar item after activation
   statusBarItemHandler.show();
 }

editors/vscode/client/tools/ToolInterface.ts

@@ -3,11 +3,20 @@ import { ConfigService } from '../ConfigService';
 import StatusBarItemHandler from '../StatusBarItemHandler';
 
 export default interface ToolInterface {
+  /**
+   * Gets the path to the tool's language server binary (if applicable).
+   */
+  getBinary(
+    context: ExtensionContext,
+    outputChannel: LogOutputChannel,
+    configService: ConfigService,
+  ): Promise<string | undefined>;
   /**
    * Activates the tool and initializes any necessary resources.
    */
   activate(
     context: ExtensionContext,
+    binaryPath: string,
     outputChannel: LogOutputChannel,
     configService: ConfigService,
     statusBarItemHandler: StatusBarItemHandler,

editors/vscode/client/tools/linter.ts

@@ -28,8 +28,28 @@ export default class LinterTool implements ToolInterface {
   // LSP client instance
   private client: LanguageClient | undefined;
 
+  async getBinary(
+    context: ExtensionContext,
+    outputChannel: LogOutputChannel,
+    configService: ConfigService,
+  ): Promise<string | undefined> {
+    const bin = configService.getUserServerBinPath();
+    if (workspace.isTrusted && bin) {
+      try {
+        await fsPromises.access(bin);
+        return bin;
+      } catch (e) {
+        outputChannel.error(`Invalid bin path: ${bin}`, e);
+      }
+    }
+    const ext = process.platform === 'win32' ? '.exe' : '';
+    // NOTE: The `./target/release` path is aligned with the path defined in .github/workflows/release_vscode.yml
+    return process.env.SERVER_PATH_DEV ?? join(context.extensionPath, `./target/release/oxc_language_server${ext}`);
+  }
+
   async activate(
     context: ExtensionContext,
+    binaryPath: string,
     outputChannel: LogOutputChannel,
     configService: ConfigService,
     statusBarItemHandler: StatusBarItemHandler,
@@ -63,30 +83,13 @@ export default class LinterTool implements ToolInterface {
 
     context.subscriptions.push(applyAllFixesFile);
 
-    async function findBinary(): Promise<string> {
-      const bin = configService.getUserServerBinPath();
-      if (workspace.isTrusted && bin) {
-        try {
-          await fsPromises.access(bin);
-          return bin;
-        } catch (e) {
-          outputChannel.error(`Invalid bin path: ${bin}`, e);
-        }
-      }
-      const ext = process.platform === 'win32' ? '.exe' : '';
-      // NOTE: The `./target/release` path is aligned with the path defined in .github/workflows/release_vscode.yml
-      return process.env.SERVER_PATH_DEV ?? join(context.extensionPath, `./target/release/oxc_language_server${ext}`);
-    }
-
-    const path = await findBinary();
-
-    const run: Executable = runExecutable(path, configService.vsCodeConfig.nodePath);
+    const run: Executable = runExecutable(binaryPath, configService.vsCodeConfig.nodePath);
     const serverOptions: ServerOptions = {
       run,
       debug: run,
     };
 
-    outputChannel.info(`Using server binary at: ${path}`);
+    outputChannel.info(`Using server binary at: ${binaryPath}`);
 
     // see https://github.com/oxc-project/oxc/blob/9b475ad05b750f99762d63094174be6f6fc3c0eb/crates/oxc_linter/src/loader/partial_loader/mod.rs#L17-L20
     const supportedExtensions = ['astro', 'cjs', 'cts', 'js', 'jsx', 'mjs', 'mts', 'svelte', 'ts', 'tsx', 'vue'];