Skip to content

Commit 61c94ea

Browse files
Copilotcamc314
andcommitted
Update snapshots after fixing duplicate export modifier diagnostic
- Updated parser_misc.snap to include new test case - Updated parser_typescript.snap to reflect correct diagnostic message Co-authored-by: camc314 <[email protected]>
1 parent 4ed6304 commit 61c94ea

File tree

2 files changed

+43
-142
lines changed

2 files changed

+43
-142
lines changed

tasks/coverage/snapshots/parser_misc.snap

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
parser_misc Summary:
22
AST Parsed : 51/51 (100.00%)
33
Positive Passed: 51/51 (100.00%)
4-
Negative Passed: 118/118 (100.00%)
4+
Negative Passed: 119/119 (100.00%)
55

66
× Cannot assign to 'arguments' in strict mode
77
╭─[misc/fail/arguments-eval.ts:1:10]
@@ -72,6 +72,14 @@ Negative Passed: 118/118 (100.00%)
7272
If you're in the middle of a rebase, the top section is the code being rebased onto and the bottom section is the code coming from the current commit being rebased.
7373
If you have nested conflicts, resolve the outermost conflict first.
7474

75+
× TS(1030): 'export' modifier already seen.
76+
╭─[misc/fail/duplicate-export-modifier.ts:1:8]
77+
1export export function foo() {
78+
· ──────
79+
2 │ }
80+
╰────
81+
help: Remove the duplicate modifier.
82+
7583
× '0'-prefixed octal literals and octal escape sequences are deprecated
7684
╭─[misc/fail/escape-00.js:1:25]
7785
1export const escape00 = "\00";

tasks/coverage/snapshots/parser_typescript.snap

Lines changed: 34 additions & 141 deletions
Original file line numberDiff line numberDiff line change
@@ -6082,175 +6082,95 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
60826082
· ────────────────
60836083
╰────
60846084

6085-
× TS(1029): 'export' modifier must precede 'declare' modifier.
6085+
× TS(1030): 'export' modifier already seen.
60866086
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:2:12]
60876087
1 │ namespace M {
60886088
2 │ export export var x = 1;
60896089
· ──────
60906090
3 │ export export function f() { }
60916091
╰────
6092+
help: Remove the duplicate modifier.
60926093

6093-
× 'export' modifier cannot be used here.
6094-
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:2:12]
6095-
1 │ namespace M {
6096-
2 │ export export var x = 1;
6097-
· ──────
6098-
3 │ export export function f() { }
6099-
╰────
6100-
help: Only 'declare' modifier is allowed here.
6101-
6102-
× TS(1029): 'export' modifier must precede 'declare' modifier.
6103-
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:3:12]
6104-
2 │ export export var x = 1;
6105-
3 │ export export function f() { }
6106-
· ──────
6107-
4 │
6108-
╰────
6109-
6110-
× 'export' modifier cannot be used here.
6094+
× TS(1030): 'export' modifier already seen.
61116095
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:3:12]
61126096
2 │ export export var x = 1;
61136097
3 │ export export function f() { }
61146098
· ──────
61156099
4 │
61166100
╰────
6117-
help: Allowed modifiers are: declare, async
6101+
help: Remove the duplicate modifier.
61186102

6119-
× TS(1029): 'export' modifier must precede 'declare' modifier.
6103+
× TS(1030): 'export' modifier already seen.
61206104
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:5:12]
61216105
4 │
61226106
5 │ export export namespace N {
61236107
· ──────
61246108
6 │ export export class C { }
61256109
╰────
6110+
help: Remove the duplicate modifier.
61266111

6127-
× TS(1029): 'export' modifier must precede 'declare' modifier.
6128-
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:6:16]
6129-
5 │ export export namespace N {
6130-
6 │ export export class C { }
6131-
· ──────
6132-
7 │ export export interface I { }
6133-
╰────
6134-
6135-
× 'export' modifier cannot be used here.
6112+
× TS(1030): 'export' modifier already seen.
61366113
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:6:16]
61376114
5 │ export export namespace N {
61386115
6 │ export export class C { }
61396116
· ──────
61406117
7 │ export export interface I { }
61416118
╰────
6142-
help: Allowed modifiers are: declare, abstract
6143-
6144-
× TS(1029): 'export' modifier must precede 'declare' modifier.
6145-
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:7:16]
6146-
6 │ export export class C { }
6147-
7 │ export export interface I { }
6148-
· ──────
6149-
8 │ }
6150-
╰────
6119+
help: Remove the duplicate modifier.
61516120

6152-
× 'export' modifier cannot be used here.
6121+
× TS(1030): 'export' modifier already seen.
61536122
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:7:16]
61546123
6 │ export export class C { }
61556124
7 │ export export interface I { }
61566125
· ──────
61576126
8 │ }
61586127
╰────
6159-
help: Only 'declare' modifier is allowed here.
6160-
6161-
× 'export' modifier cannot be used here.
6162-
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:5:12]
6163-
4 │
6164-
5 │ export export namespace N {
6165-
· ──────
6166-
6 │ export export class C { }
6167-
╰────
6168-
help: Only 'declare' modifier is allowed here.
6169-
6170-
× TS(1029): 'export' modifier must precede 'declare' modifier.
6171-
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:12:12]
6172-
11 │ declare namespace A {
6173-
12 │ export export var x;
6174-
· ──────
6175-
13 │ export export function f()
6176-
╰────
6128+
help: Remove the duplicate modifier.
61776129

6178-
× 'export' modifier cannot be used here.
6130+
× TS(1030): 'export' modifier already seen.
61796131
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:12:12]
61806132
11 │ declare namespace A {
61816133
12 │ export export var x;
61826134
· ──────
61836135
13 │ export export function f()
61846136
╰────
6185-
help: Only 'declare' modifier is allowed here.
6186-
6187-
× TS(1029): 'export' modifier must precede 'declare' modifier.
6188-
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:13:12]
6189-
12 │ export export var x;
6190-
13 │ export export function f()
6191-
· ──────
6192-
14 │
6193-
╰────
6137+
help: Remove the duplicate modifier.
61946138

6195-
× 'export' modifier cannot be used here.
6139+
× TS(1030): 'export' modifier already seen.
61966140
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:13:12]
61976141
12 │ export export var x;
61986142
13 │ export export function f()
61996143
· ──────
62006144
14 │
62016145
╰────
6202-
help: Allowed modifiers are: declare, async
6146+
help: Remove the duplicate modifier.
62036147

6204-
× TS(1029): 'export' modifier must precede 'declare' modifier.
6148+
× TS(1030): 'export' modifier already seen.
62056149
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:15:12]
62066150
14 │
62076151
15 │ export export namespace N {
62086152
· ──────
62096153
16 │ export export class C { }
62106154
╰────
6155+
help: Remove the duplicate modifier.
62116156

6212-
× TS(1029): 'export' modifier must precede 'declare' modifier.
6213-
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:16:16]
6214-
15 │ export export namespace N {
6215-
16 │ export export class C { }
6216-
· ──────
6217-
17 │ export export interface I { }
6218-
╰────
6219-
6220-
× 'export' modifier cannot be used here.
6157+
× TS(1030): 'export' modifier already seen.
62216158
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:16:16]
62226159
15 │ export export namespace N {
62236160
16 │ export export class C { }
62246161
· ──────
62256162
17 │ export export interface I { }
62266163
╰────
6227-
help: Allowed modifiers are: declare, abstract
6228-
6229-
× TS(1029): 'export' modifier must precede 'declare' modifier.
6230-
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:17:16]
6231-
16 │ export export class C { }
6232-
17 │ export export interface I { }
6233-
· ──────
6234-
18 │ }
6235-
╰────
6164+
help: Remove the duplicate modifier.
62366165

6237-
× 'export' modifier cannot be used here.
6166+
× TS(1030): 'export' modifier already seen.
62386167
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:17:16]
62396168
16 │ export export class C { }
62406169
17 │ export export interface I { }
62416170
· ──────
62426171
18 │ }
62436172
╰────
6244-
help: Only 'declare' modifier is allowed here.
6245-
6246-
× 'export' modifier cannot be used here.
6247-
╭─[typescript/tests/cases/compiler/exportAlreadySeen.ts:15:12]
6248-
14 │
6249-
15 │ export export namespace N {
6250-
· ──────
6251-
16 │ export export class C { }
6252-
╰────
6253-
help: Only 'declare' modifier is allowed here.
6173+
help: Remove the duplicate modifier.
62546174

62556175
× Unexpected token
62566176
╭─[typescript/tests/cases/compiler/exportAssignmentWithDeclareAndExportModifiers.ts:2:16]
@@ -6600,13 +6520,14 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
66006520
3 │ export function f() { }
66016521
╰────
66026522

6603-
× TS(1029): 'export' modifier must precede 'declare' modifier.
6523+
× TS(1030): 'export' modifier already seen.
66046524
╭─[typescript/tests/cases/compiler/functionsWithModifiersInBlocks1.ts:4:12]
66056525
3 │ export function f() { }
66066526
4 │ declare export function f() { }
66076527
· ──────
66086528
5 │ }
66096529
╰────
6530+
help: Remove the duplicate modifier.
66106531

66116532
× TS(1183): An implementation cannot be declared in ambient contexts.
66126533
╭─[typescript/tests/cases/compiler/functionsWithModifiersInBlocks1.ts:4:32]
@@ -6616,15 +6537,6 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
66166537
5 │ }
66176538
╰────
66186539

6619-
× 'export' modifier cannot be used here.
6620-
╭─[typescript/tests/cases/compiler/functionsWithModifiersInBlocks1.ts:4:12]
6621-
3 │ export function f() { }
6622-
4 │ declare export function f() { }
6623-
· ──────
6624-
5 │ }
6625-
╰────
6626-
help: Allowed modifiers are: declare, async
6627-
66286540
× Unexpected token
66296541
╭─[typescript/tests/cases/compiler/genericCallWithoutArgs.ts:4:18]
66306542
3 │
@@ -6753,21 +6665,23 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
67536665
2 │
67546666
╰────
67556667

6756-
× TS(1029): 'export' modifier must precede 'declare' modifier.
6668+
× TS(1030): 'export' modifier already seen.
67576669
╭─[typescript/tests/cases/compiler/importDeclWithDeclareModifier.ts:5:9]
67586670
4 │ }
67596671
5 │ declare export import a = x.c;
67606672
· ──────
67616673
6 │ var b: a;
67626674
╰────
6675+
help: Remove the duplicate modifier.
67636676

6764-
× TS(1029): 'export' modifier must precede 'declare' modifier.
6677+
× TS(1030): 'export' modifier already seen.
67656678
╭─[typescript/tests/cases/compiler/importDeclWithDeclareModifierInAmbientContext.ts:6:13]
67666679
5 │ }
67676680
6 │ declare export import a = x.c;
67686681
· ──────
67696682
7 │ var b: a;
67706683
╰────
6684+
help: Remove the duplicate modifier.
67716685

67726686
× Cannot use import statement outside a module
67736687
╭─[typescript/tests/cases/compiler/importDeclarationInModuleDeclaration2.ts:2:5]
@@ -9663,22 +9577,14 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
96639577
· ──────
96649578
╰────
96659579

9666-
× TS(1029): 'export' modifier must precede 'declare' modifier.
9667-
╭─[typescript/tests/cases/compiler/privacyImportParseErrors.ts:326:9]
9668-
325 │
9669-
326 │ declare export module "anotherParseError2" {
9670-
· ──────
9671-
327 │ namespace m2 {
9672-
╰────
9673-
9674-
× 'export' modifier cannot be used here.
9580+
× TS(1030): 'export' modifier already seen.
96759581
╭─[typescript/tests/cases/compiler/privacyImportParseErrors.ts:326:9]
96769582
325 │
96779583
326 │ declare export module "anotherParseError2" {
96789584
· ──────
96799585
327 │ namespace m2 {
96809586
╰────
9681-
help: Only 'declare' modifier is allowed here.
9587+
help: Remove the duplicate modifier.
96829588

96839589
× Unexpected token
96849590
╭─[typescript/tests/cases/compiler/privateNameJsx.tsx:4:22]
@@ -19591,13 +19497,14 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
1959119497
· ╰── Opened here
1959219498
╰────
1959319499

19594-
× TS(1029): 'export' modifier must precede 'declare' modifier.
19500+
× TS(1030): 'export' modifier already seen.
1959519501
╭─[typescript/tests/cases/conformance/externalModules/umd-errors.ts:3:8]
1959619502
2 │ export var p;
1959719503
3 │ static export as namespace oo1;
1959819504
· ──────
1959919505
4 │ declare export as namespace oo2;
1960019506
╰────
19507+
help: Remove the duplicate modifier.
1960119508

1960219509
× Unexpected token
1960319510
╭─[typescript/tests/cases/conformance/externalModules/umd-errors.ts:3:15]
@@ -22077,20 +21984,13 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
2207721984
╰────
2207821985
help: Only 'declare' modifier is allowed here.
2207921986

22080-
× TS(1029): 'export' modifier must precede 'declare' modifier.
21987+
× TS(1030): 'export' modifier already seen.
2208121988
╭─[typescript/tests/cases/conformance/parser/ecmascript5/InterfaceDeclarations/parserInterfaceDeclaration6.ts:1:8]
2208221989
1 │ export export interface I {
2208321990
· ──────
2208421991
2 │ }
2208521992
╰────
22086-
22087-
× 'export' modifier cannot be used here.
22088-
╭─[typescript/tests/cases/conformance/parser/ecmascript5/InterfaceDeclarations/parserInterfaceDeclaration6.ts:1:8]
22089-
1 │ export export interface I {
22090-
· ──────
22091-
2 │ }
22092-
╰────
22093-
help: Only 'declare' modifier is allowed here.
21993+
help: Remove the duplicate modifier.
2209421994

2209521995
× TS(2414): Interface name cannot be 'string'
2209621996
╭─[typescript/tests/cases/conformance/parser/ecmascript5/InterfaceDeclarations/parserInterfaceDeclaration8.ts:1:11]
@@ -22592,20 +22492,13 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
2259222492
3 │ }
2259322493
╰────
2259422494

22595-
× TS(1029): 'export' modifier must precede 'declare' modifier.
22495+
× TS(1030): 'export' modifier already seen.
2259622496
╭─[typescript/tests/cases/conformance/parser/ecmascript5/RegressionTests/parser618973.ts:1:8]
2259722497
1 │ export export class Foo {
2259822498
· ──────
2259922499
2 │ public Bar() {
2260022500
╰────
22601-
22602-
× 'export' modifier cannot be used here.
22603-
╭─[typescript/tests/cases/conformance/parser/ecmascript5/RegressionTests/parser618973.ts:1:8]
22604-
1 │ export export class Foo {
22605-
· ──────
22606-
2 │ public Bar() {
22607-
╰────
22608-
help: Allowed modifiers are: declare, abstract
22501+
help: Remove the duplicate modifier.
2260922502

2261022503
× The keyword 'static' is reserved
2261122504
╭─[typescript/tests/cases/conformance/parser/ecmascript5/RegressionTests/parser642331.ts:2:18]

0 commit comments

Comments
 (0)