refactor(napi/parser): move clippy attrs onto NAPI functions (#16236)

Pure refactor. Remove blanket disable of `clippy::needless_pass_by_value` lint rule, and disable it on individual NAPI functions instead. This reveals one other function which was taking a `String` when it could take a `&str`.

Author: overlookmotel

napi/parser/src/lib.rs

@@ -1,6 +1,3 @@
-// Napi value need to be passed as value
-#![expect(clippy::needless_pass_by_value)]
-
 #[cfg(all(
     feature = "allocator",
     not(any(target_arch = "arm", target_os = "freebsd", target_family = "wasm"))
@@ -87,13 +84,13 @@ fn parse_impl<'a>(
         .parse()
 }
 
-fn parse_with_return(filename: &str, source_text: String, options: &ParserOptions) -> ParseResult {
+fn parse_with_return(filename: &str, source_text: &str, options: &ParserOptions) -> ParseResult {
     let allocator = Allocator::default();
     let source_type =
         get_source_type(filename, options.lang.as_deref(), options.source_type.as_deref());
     let ast_type = get_ast_type(source_type, options);
     let ranges = options.range.unwrap_or(false);
-    let ret = parse_impl(&allocator, source_type, &source_text, options);
+    let ret = parse_impl(&allocator, source_type, source_text, options);
 
     let mut program = ret.program;
     let mut module_record = ret.module_record;
@@ -104,10 +101,10 @@ fn parse_with_return(filename: &str, source_text: String, options: &ParserOption
         diagnostics.extend(semantic_ret.errors);
     }
 
-    let mut errors = OxcError::from_diagnostics(filename, &source_text, diagnostics);
+    let mut errors = OxcError::from_diagnostics(filename, source_text, diagnostics);
 
     let mut comments =
-        convert_utf8_to_utf16(&source_text, &mut program, &mut module_record, &mut errors);
+        convert_utf8_to_utf16(source_text, &mut program, &mut module_record, &mut errors);
 
     let program_and_fixes = match ast_type {
         AstType::JavaScript => {
@@ -142,13 +139,14 @@ fn parse_with_return(filename: &str, source_text: String, options: &ParserOption
 
 /// Parse synchronously.
 #[napi]
+#[allow(clippy::needless_pass_by_value, clippy::allow_attributes)]
 pub fn parse_sync(
     filename: String,
     source_text: String,
     options: Option<ParserOptions>,
 ) -> ParseResult {
     let options = options.unwrap_or_default();
-    parse_with_return(&filename, source_text, &options)
+    parse_with_return(&filename, &source_text, &options)
 }
 
 pub struct ResolveTask {
@@ -164,7 +162,7 @@ impl Task for ResolveTask {
 
     fn compute(&mut self) -> napi::Result<Self::Output> {
         let source_text = mem::take(&mut self.source_text);
-        Ok(parse_with_return(&self.filename, source_text, &self.options))
+        Ok(parse_with_return(&self.filename, &source_text, &self.options))
     }
 
     fn resolve(&mut self, _: napi::Env, result: Self::Output) -> napi::Result<Self::JsValue> {

napi/parser/src/raw_transfer.rs

@@ -44,6 +44,7 @@ const BUMP_ALIGN: usize = 16;
 /// Does not check that the offset is within bounds of `buffer`.
 /// To ensure it always is, provide a `Uint8Array` of at least `BUFFER_SIZE + BUFFER_ALIGN` bytes.
 #[napi(skip_typescript)]
+#[allow(clippy::needless_pass_by_value, clippy::allow_attributes)]
 pub fn get_buffer_offset(buffer: Uint8Array) -> u32 {
     let buffer = &*buffer;
     let offset = (BUFFER_ALIGN - (buffer.as_ptr() as usize % BUFFER_ALIGN)) % BUFFER_ALIGN;
@@ -76,6 +77,7 @@ pub fn get_buffer_offset(buffer: Uint8Array) -> u32 {
 ///
 /// Panics if source text is too long, or AST takes more memory than is available in the buffer.
 #[napi(skip_typescript)]
+#[allow(clippy::needless_pass_by_value, clippy::allow_attributes)]
 pub unsafe fn parse_raw_sync(
     filename: String,
     mut buffer: Uint8Array,