Skip to content

Commit e4d70d4

Browse files
Copilotsapphi-red
andcommitted
Address review feedback: remove .serena files and add more test cases
Co-authored-by: sapphi-red <[email protected]>
1 parent 14052b5 commit e4d70d4

File tree

6 files changed

+28
-233
lines changed

6 files changed

+28
-233
lines changed

.serena/memories/project_overview.md

Lines changed: 0 additions & 42 deletions
This file was deleted.

.serena/memories/style_and_conventions.md

Lines changed: 0 additions & 44 deletions
This file was deleted.

.serena/memories/suggested_commands.md

Lines changed: 0 additions & 97 deletions
This file was deleted.

.serena/memories/task_completion.md

Lines changed: 0 additions & 50 deletions
This file was deleted.

crates/oxc_codegen/tests/integration/comments.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,13 @@ catch(e) {
184184
// Inline comment between catch param and body
185185
"try { console.log('test'); }
186186
catch (err) /* v8 ignore next */ { console.error(err); }",
187+
// Multiple comments between catch param and body
188+
"try { something(); }
189+
catch (err) /* c8 ignore next */ /* istanbul ignore next */ { handle(err); }",
190+
// Line comment between catch param and body
191+
"try { something(); }
192+
catch (err) // v8 ignore next
193+
{ handle(err); }",
187194
];
188195

189196
snapshot("coverage", &cases);

crates/oxc_codegen/tests/integration/snapshots/coverage.snap

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,3 +120,24 @@ try {
120120
console.error(err);
121121
}
122122

123+
########## 21
124+
try { something(); }
125+
catch (err) /* c8 ignore next */ /* istanbul ignore next */ { handle(err); }
126+
----------
127+
try {
128+
something();
129+
} catch (err) /* c8 ignore next *//* istanbul ignore next */ {
130+
handle(err);
131+
}
132+
133+
########## 22
134+
try { something(); }
135+
catch (err) // v8 ignore next
136+
{ handle(err); }
137+
----------
138+
try {
139+
something();
140+
} catch (err) {
141+
handle(err);
142+
}
143+

0 commit comments

Comments
 (0)