Should I run tsc after oxlint?

[Profesor08]

There are some scripts from my package.json. When I run npm run check, it rund all check:* scripts. They run one by one, order is not important. In my case, code is checked by oxlint and by tsc. May be running tsc is not necessary, because oxlint hadles all cases, or it is not?

{
  "scripts": {
    "dev": "rsbuild dev",
    "test": "rstest",
    "check:format": "oxfmt --check",
    "check:lint": "oxlint --type-aware --type-check",
    "check:types": "tsc",
    "check:style": "stylelint \"./src/**/*.css\" \"./src/styles/**/*.css\"",
    "check": "run-s check:* test",
    "build": "rsbuild build",
    "build:prod": "run-s build sentry:*",
    "deploy": "run-s check build",
    "deploy:prod": "run-s check build:prod",
    "sentry:inject": "sentry-cli sourcemaps inject ./dist --quiet",
    "sentry:upload": "sentry-cli sourcemaps upload ./dist --silent",
    "knip": "knip",
    "rsdoctor": "rsbuild build --env-mode rsdoctor",
    "preview": "rsbuild preview"
  },
}

[camc314]

The answer is it depends!

I can se that you're using --type-check and --type-aware - we perform all the same sort of checks that tsc will be doing, so running tsc is unceccessary. that said, if you're inside a monorepo, and are relying on the emitted-output of tsc, it's still necessary to run it!