fix(linter/plugins): reset state after error during AST visitation #16246
Conversation
github-actions
bot
added
A-linter
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
force-pushed
the
11-28-fix_linter_plugins_reset_state_after_error_during_ast_visitation
branch
from
4d8c1a9 to
fdab22e
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes a memory leak issue by ensuring that file processing state is properly cleaned up after errors during AST visitation. The fix extracts the cleanup logic into a dedicated resetFile() function and ensures it's called in the finally block of lintFile().
Key Changes:
- Added
resetFile()call in the finally block to ensure cleanup happens even when errors occur - Extracted reset logic into a separate documented function for better code organization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge activity
|
…16246) If there's an error during AST visitation, ensure state is reset to free memory. This is only observable if user were to schedule some code in a later tick to access e.g. `sourceCode.text`, and that runs before the next file is linted. I've not added tests, as it'd be hard to write one which isn't flaky.
graphite-app
bot
force-pushed
the
11-28-fix_linter_plugins_reset_state_after_error_during_ast_visitation
branch
from
fdab22e to
0df1901
Compare
graphite-app
bot
deleted the
11-28-fix_linter_plugins_reset_state_after_error_during_ast_visitation
branch
If there's an error during AST visitation, ensure state is reset to free memory.
This is only observable if user were to schedule some code in a later tick to access e.g.
sourceCode.text, and that runs before the next file is linted. I've not added tests, as it'd be hard to write one which isn't flaky.