Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 29, 2025

Implement SourceCode#getNodeByRangeIndex method.

Behaves the same as ESLint's version, but this implementation should be more performant as it's much simpler, avoiding ESLint's Traverser abstraction, and exiting loops earlier.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-enhancement Category - New feature or request labels Nov 29, 2025
Copy link
Member Author

overlookmotel commented Nov 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review November 29, 2025 02:38
@overlookmotel overlookmotel self-assigned this Nov 29, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 29, 2025
Copy link
Member Author

overlookmotel commented Nov 29, 2025

Merge activity

)

Implement `SourceCode#getNodeByRangeIndex` method.

Behaves the same as ESLint's version, but this implementation should be more performant as it's much simpler, avoiding ESLint's `Traverser` abstraction, and exiting loops earlier.
@graphite-app graphite-app bot force-pushed the 11-28-fix_linter_plugins_reset_state_after_error_during_ast_visitation branch from fdab22e to 0df1901 Compare November 29, 2025 02:42
@graphite-app graphite-app bot force-pushed the 11-28-feat_linter_plugins_implement_sourcecode_getnodebyrangeindex_ branch from 2d68a5a to 7150209 Compare November 29, 2025 02:43
Base automatically changed from 11-28-fix_linter_plugins_reset_state_after_error_during_ast_visitation to main November 29, 2025 02:48
@graphite-app graphite-app bot merged commit 7150209 into main Nov 29, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 11-28-feat_linter_plugins_implement_sourcecode_getnodebyrangeindex_ branch November 29, 2025 02:48
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants