Merge pull request #214 from Lucccyo/sig_help_looping_parameter

Signature help should not loop over the parameters once it is finished

Author: ikostia

src/frontend/query_commands.ml

@@ -1068,8 +1068,11 @@ let dispatch pipeline (type a) : a Query_protocol.t -> a = function
     in
     match application_signature with
     | Some s ->
+      (* The signature help should not appear on the name of the function. *)
       if Msource.compare_position source position s.function_position < 0 then
         None
+        (* The signature help should not appear after the last parameter. *)
+      else if s.active_param = None then None
       else
         let prefix =
           let fun_name = Option.value ~default:"_" s.function_name in

tests/test-dirs/signature-help/issue_looping_param.t

@@ -0,0 +1,47 @@
+  $ $MERLIN single signature-help -position 2:14 <<EOF
+  > let f x y z = x + y + z
+  > let a = f 4 4 
+  > EOF
+  {
+    "class": "return",
+    "value": {
+      "signatures": [
+        {
+          "label": "f : int -> int -> int -> int",
+          "parameters": [
+            {
+              "label": [
+                4,
+                7
+              ]
+            },
+            {
+              "label": [
+                11,
+                14
+              ]
+            },
+            {
+              "label": [
+                18,
+                21
+              ]
+            }
+          ]
+        }
+      ],
+      "activeParameter": 2,
+      "activeSignature": 0
+    },
+    "notifications": []
+  }
+
+  $ $MERLIN single signature-help -position 2:16 <<EOF
+  > let f x y z = x + y + z
+  > let a = f 4 4 4 
+  > EOF
+  {
+    "class": "return",
+    "value": {},
+    "notifications": []
+  }