Check the optional active_param which should not trigger the signature help if none

Author: Lucccyo

src/frontend/query_commands.ml

@@ -956,8 +956,11 @@ let dispatch pipeline (type a) : a Query_protocol.t -> a = function
     in
     match application_signature with
     | Some s ->
+      (* The signature help should not appear on the name of the function. *)
       if Msource.compare_position source position s.function_position < 0 then
         None
+        (* The signature help should not appear after the last parameter. *)
+      else if s.active_param = None then None
       else
         let prefix =
           let fun_name = Option.value ~default:"_" s.function_name in

tests/test-dirs/signature-help/issue_looping_param.t

@@ -36,41 +36,12 @@
     "notifications": []
   }
 
-FIXME: Once the function has all of its parameters, it should not loop again on the parameters
   $ $MERLIN single signature-help -position 2:16 <<EOF
   > let f x y z = x + y + z
   > let a = f 4 4 4 
   > EOF
   {
     "class": "return",
-    "value": {
-      "signatures": [
-        {
-          "label": "f : int -> int -> int -> int",
-          "parameters": [
-            {
-              "label": [
-                4,
-                7
-              ]
-            },
-            {
-              "label": [
-                11,
-                14
-              ]
-            },
-            {
-              "label": [
-                18,
-                21
-              ]
-            }
-          ]
-        }
-      ],
-      "activeParameter": 0,
-      "activeSignature": 0
-    },
+    "value": {},
     "notifications": []
   }