Fail to detect running testnet if flag is passed through config file

[darcys22]

It appears that if we run storage server and pass the testnet flag via a config file such as done in the deb packages then it fails to detect that we are in testnet. This causes issues as it tries to connect to oxend via /var/lib/oxen/oxend.sock instead of /var/lib/oxen/testnet/oxend.sock

Error appears to be resulting from this search:

oxen-storage-server/oxenss/daemon/command_line.cpp

Line 104 in 9c62bd2

for (int i = 1; i < argc; i++) {

Where it specifically searches for --testnet

Workaround possible on debs by changing the systemd service file to use storage-server --testnet --config-file /etc/oxen/storage-testnet.conf and specify testnet there instead of the config file

[martin-braun]

And since

auto base_dir = get_home_dir().value_or(fs::current_path());
//...
options.oxend_omq_rpc = "ipc://" + (base_dir / "oxend.sock").u8string();

the sock path doesn't react to data dir changes, either, it will always search in the home dir, making it necessary to modify the home dir or provide oxend-rpc in the configuration. The latter approach will prevent the issue in any case.